You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/15 21:45:22 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request, #36882: [SPARK-39468][CORE][FOLLOWUP] Use 'lazy val' for host

dongjoon-hyun opened a new pull request, #36882:
URL: https://github.com/apache/spark/pull/36882

   ### What changes were proposed in this pull request?
   
   This PR aims to use `lazy val host` instead of `val host`.
   
   ### Why are the changes needed?
   
   To address the review comments about `RpcAddress` object size.
   - https://github.com/apache/spark/pull/36868#discussion_r898235985
   - https://github.com/apache/spark/pull/36868#discussion_r898332785
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] mridulm commented on pull request #36882: [SPARK-39468][CORE][FOLLOWUP] Use `lazy val` for `host`

Posted by GitBox <gi...@apache.org>.
mridulm commented on PR #36882:
URL: https://github.com/apache/spark/pull/36882#issuecomment-1157143900

   Thanks for fixing this @dongjoon-hyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #36882: [SPARK-39468][CORE][FOLLOWUP] Use `lazy val` for `host`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36882:
URL: https://github.com/apache/spark/pull/36882#issuecomment-1157160262

   Thank you @mridulm !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #36882: [SPARK-39468][CORE][FOLLOWUP] Use `lazy val` for `host`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36882:
URL: https://github.com/apache/spark/pull/36882#issuecomment-1157098472

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #36882: [SPARK-39468][CORE][FOLLOWUP] Use `lazy val` for `host`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36882:
URL: https://github.com/apache/spark/pull/36882#issuecomment-1157238708

   Oh, Thank you for approval and merging, @HyukjinKwon , too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #36882: [SPARK-39468][CORE][FOLLOWUP] Use `lazy val` for `host`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36882: [SPARK-39468][CORE][FOLLOWUP] Use `lazy val` for `host`
URL: https://github.com/apache/spark/pull/36882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org