You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Mayank Mishra (JIRA)" <ji...@apache.org> on 2008/11/17 10:50:44 UTC

[jira] Created: (CXF-1917) Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation

Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation
-------------------------------------------------------------------------------------

                 Key: CXF-1917
                 URL: https://issues.apache.org/jira/browse/CXF-1917
             Project: CXF
          Issue Type: Improvement
          Components: Core
    Affects Versions: 2.0.7
         Environment: Windows XP, Java SE 1.6
            Reporter: Mayank Mishra
            Priority: Minor


AttachmentDeserializer contains static java.util.regex.Patterns which compiled for particular String expressions, which takes substantial time in milliseconds (around 50-100 ms). 

AttachmentDeserializer instance is created in AttachmentInInterceptor during handleMessage() call. This can be moved to AttachmentInInterceptor constructor, and provided a setMessage(Message message) method in AttachmentDerserializer, we can set message during handleMessage() call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-1917) Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation

Posted by "Mayank Mishra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mayank Mishra updated CXF-1917:
-------------------------------

    Attachment: AttachmentInInterceptor.patch
                AttachmentDeserializer.patch

Attaching AttachmentDeserializer and AttachmentInInterceptor patch files.



> Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation
> -------------------------------------------------------------------------------------
>
>                 Key: CXF-1917
>                 URL: https://issues.apache.org/jira/browse/CXF-1917
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.7
>         Environment: Windows XP, Java SE 1.6
>            Reporter: Mayank Mishra
>            Priority: Minor
>         Attachments: AttachmentDeserializer.patch, AttachmentInInterceptor.patch
>
>
> AttachmentDeserializer contains static java.util.regex.Patterns which compiled for particular String expressions, which takes substantial time in milliseconds (around 50-100 ms). 
> AttachmentDeserializer instance is created in AttachmentInInterceptor during handleMessage() call. This can be moved to AttachmentInInterceptor constructor, and provided a setMessage(Message message) method in AttachmentDerserializer, we can set message during handleMessage() call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-1917) Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-1917.
------------------------------

       Resolution: Invalid
    Fix Version/s: Invalid

> Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation
> -------------------------------------------------------------------------------------
>
>                 Key: CXF-1917
>                 URL: https://issues.apache.org/jira/browse/CXF-1917
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.7
>         Environment: Windows XP, Java SE 1.6
>            Reporter: Mayank Mishra
>            Assignee: Daniel Kulp
>            Priority: Minor
>             Fix For: Invalid
>
>         Attachments: AttachmentDeserializer.patch, AttachmentInInterceptor.patch
>
>
> AttachmentDeserializer contains static java.util.regex.Patterns which compiled for particular String expressions, which takes substantial time in milliseconds (around 50-100 ms). 
> AttachmentDeserializer instance is created in AttachmentInInterceptor during handleMessage() call. This can be moved to AttachmentInInterceptor constructor, and provided a setMessage(Message message) method in AttachmentDerserializer, we can set message during handleMessage() call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CXF-1917) Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp reassigned CXF-1917:
--------------------------------

    Assignee: Daniel Kulp

> Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation
> -------------------------------------------------------------------------------------
>
>                 Key: CXF-1917
>                 URL: https://issues.apache.org/jira/browse/CXF-1917
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.7
>         Environment: Windows XP, Java SE 1.6
>            Reporter: Mayank Mishra
>            Assignee: Daniel Kulp
>            Priority: Minor
>         Attachments: AttachmentDeserializer.patch, AttachmentInInterceptor.patch
>
>
> AttachmentDeserializer contains static java.util.regex.Patterns which compiled for particular String expressions, which takes substantial time in milliseconds (around 50-100 ms). 
> AttachmentDeserializer instance is created in AttachmentInInterceptor during handleMessage() call. This can be moved to AttachmentInInterceptor constructor, and provided a setMessage(Message message) method in AttachmentDerserializer, we can set message during handleMessage() call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-1917) Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648368#action_12648368 ] 

Daniel Kulp commented on CXF-1917:
----------------------------------


Ummm... no it cannot be moved into AttachmentInInterceptor.    The interceptors are re-entrant.  Thus, there could be multiple threads currently in the AttachmentInInterceptor, all with their own message and thus, there would be all kinds of issues if they all called ad.setMessage(...) at the same time.

I also don't know what the problem is.   The Patter is a static.   Thus, it's compiled once and only once.   They aren't compiled for every message.



> Mtom Performance - AttachmentDeserializer's regex.Patterns compiles during invocation
> -------------------------------------------------------------------------------------
>
>                 Key: CXF-1917
>                 URL: https://issues.apache.org/jira/browse/CXF-1917
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.7
>         Environment: Windows XP, Java SE 1.6
>            Reporter: Mayank Mishra
>            Priority: Minor
>         Attachments: AttachmentDeserializer.patch, AttachmentInInterceptor.patch
>
>
> AttachmentDeserializer contains static java.util.regex.Patterns which compiled for particular String expressions, which takes substantial time in milliseconds (around 50-100 ms). 
> AttachmentDeserializer instance is created in AttachmentInInterceptor during handleMessage() call. This can be moved to AttachmentInInterceptor constructor, and provided a setMessage(Message message) method in AttachmentDerserializer, we can set message during handleMessage() call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.