[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #479: [ISSUE #473]fix configuration property get error

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479#discussion_r680624659



##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/config/ConfigurationWrapper.java
##########
@@ -80,7 +80,7 @@ public int getIntProp(String configKey, int defaultValue) {
         if (StringUtils.isEmpty(configValue)) {
             return defaultValue;
         }
-        Preconditions.checkState(StringUtils.isNumeric(configKey), String.format("%s error", configKey));
+        Preconditions.checkState(StringUtils.isNumeric(configValue), String.format("%s error", configKey));

Review comment:
       Yes, do we need to use configValue?
   or use `String.format("key:%s value:%s error", configKey, configValue)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org