You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/07/19 09:31:58 UTC

[kudu-CR] KUDU-2797 p2: the master aggregates tablet statistics

Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13426

to look at the new patch set (#22).

Change subject: KUDU-2797 p2: the master aggregates tablet statistics
......................................................................

KUDU-2797 p2: the master aggregates tablet statistics

There are some jiras are talking about metrics:
KUDU-1067, KUDU-1373, KUDU-2019, KUDU-2797.

In this patch, it makes the following improvements:
1) disk size and live row count of all the replicas are
   aggregated on the master server (only the ones that are
   the leadership roles are aggregated);
2) disk size and live row count of the table are exposed
   as metrics on the master server;
3) disk size and live row count of the table are exposed
   on the master server's Web-UI;

Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99
---
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
A src/kudu/master/table_metrics.cc
A src/kudu/master/table_metrics.h
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/heartbeater.h
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/util/metrics.cc
M www/table.mustache
20 files changed, 546 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/13426/22
-- 
To view, visit http://gerrit.cloudera.org:8080/13426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99
Gerrit-Change-Number: 13426
Gerrit-PatchSet: 22
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>