You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2017/09/27 01:51:01 UTC

Review Request 62608: Workaround to get pants working in macOS high sierra

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62608/
-----------------------------------------------------------

Review request for Aurora and John Sirois.


Repository: aurora


Description
-------

This is a cheat to use pants' thrift binary from 10.12.


Diffs
-----

  pants.ini f25e1d1a50f457325dbbabf327c31d760cb90339 


Diff: https://reviews.apache.org/r/62608/diff/1/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 62608: Workaround to get pants working in macOS high sierra

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62608/#review186366
-----------------------------------------------------------



@ReviewBot retry

The above failure looks unrelated, seems like the jenkins host ran out of physical memory.  Trying again.

- Bill Farner


On Sept. 26, 2017, 6:51 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62608/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 6:51 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a cheat to use pants' thrift binary from 10.12.
> 
> 
> Diffs
> -----
> 
>   pants.ini f25e1d1a50f457325dbbabf327c31d760cb90339 
> 
> 
> Diff: https://reviews.apache.org/r/62608/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 62608: Workaround to get pants working in macOS high sierra

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62608/#review186427
-----------------------------------------------------------



@ReviewBot retry

One last shot, i'm unable to reproduce the error.

- Bill Farner


On Sept. 26, 2017, 6:51 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62608/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 6:51 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a cheat to use pants' thrift binary from 10.12.
> 
> 
> Diffs
> -----
> 
>   pants.ini f25e1d1a50f457325dbbabf327c31d760cb90339 
> 
> 
> Diff: https://reviews.apache.org/r/62608/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 62608: Workaround to get pants working in macOS high sierra

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62608/#review186442
-----------------------------------------------------------


Ship it!




Master (474320b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 27, 2017, 1:51 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62608/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 1:51 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a cheat to use pants' thrift binary from 10.12.
> 
> 
> Diffs
> -----
> 
>   pants.ini f25e1d1a50f457325dbbabf327c31d760cb90339 
> 
> 
> Diff: https://reviews.apache.org/r/62608/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 62608: Workaround to get pants working in macOS high sierra

Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62608/#review186371
-----------------------------------------------------------


Ship it!




Ship It!

- John Sirois


On Sept. 26, 2017, 7:51 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62608/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 7:51 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a cheat to use pants' thrift binary from 10.12.
> 
> 
> Diffs
> -----
> 
>   pants.ini f25e1d1a50f457325dbbabf327c31d760cb90339 
> 
> 
> Diff: https://reviews.apache.org/r/62608/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 62608: Workaround to get pants working in macOS high sierra

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62608/#review186364
-----------------------------------------------------------



Master (79ff364) is red with this patch.
  ./build-support/jenkins/build.sh


#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map 191365120 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /home/jenkins/jenkins-slave/workspace/AuroraBot/hs_err_pid13976.log
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle aurora: instructions covered ratio is 0.76, but expected minimum is 0.87
[ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79
 FAILED

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 8' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':jacocoTestCoverageVerification'.
> Rule violated for bundle aurora: instructions covered ratio is 0.76, but expected minimum is 0.87
  Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 7m 33s
50 actionable tasks: 41 executed, 9 up-to-date


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 27, 2017, 1:51 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62608/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 1:51 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a cheat to use pants' thrift binary from 10.12.
> 
> 
> Diffs
> -----
> 
>   pants.ini f25e1d1a50f457325dbbabf327c31d760cb90339 
> 
> 
> Diff: https://reviews.apache.org/r/62608/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 62608: Workaround to get pants working in macOS high sierra

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62608/#review186367
-----------------------------------------------------------



Master (474320b) is red with this patch.
  ./build-support/jenkins/build.sh

:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:testI0927 02:59:11.180 [ShutdownHook, SchedulerMain] Stopping scheduler services. 
 FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle aurora: instructions covered ratio is 0.80, but expected minimum is 0.87
[ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is 0.70, but expected minimum is 0.79
 FAILED

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 6' finished with non-zero exit value 137

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':jacocoTestCoverageVerification'.
> Rule violated for bundle aurora: instructions covered ratio is 0.80, but expected minimum is 0.87
  Rule violated for bundle aurora: branches covered ratio is 0.70, but expected minimum is 0.79

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 8m 1s
50 actionable tasks: 41 executed, 9 up-to-date


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 27, 2017, 1:51 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62608/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 1:51 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a cheat to use pants' thrift binary from 10.12.
> 
> 
> Diffs
> -----
> 
>   pants.ini f25e1d1a50f457325dbbabf327c31d760cb90339 
> 
> 
> Diff: https://reviews.apache.org/r/62608/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>