You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2024/09/11 08:04:36 UTC
[PR] Move IdealState to group commit mode [pinot]
xiangfu0 opened a new pull request, #13976:
URL: https://github.com/apache/pinot/pull/13976
We observed IdealState update becomes bottleneck for large table with high throughput segments update.
This PR shamelessly borrowed the idea from: https://github.com/apache/helix/blob/master/helix-core/src/main/java/org/apache/helix/GroupCommit.java to group commit IdealState updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "KKcorps (via GitHub)" <gi...@apache.org>.
KKcorps commented on code in PR #13976:
URL: https://github.com/apache/pinot/pull/13976#discussion_r1753524472
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -0,0 +1,298 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils.helix;
+
+import it.unimi.dsi.fastutil.objects.ObjectBooleanImmutablePair;
+import it.unimi.dsi.fastutil.objects.ObjectBooleanPair;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.helix.AccessOption;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.PropertyKey;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.helix.zookeeper.zkclient.exception.ZkBadVersionException;
+import org.apache.pinot.common.metrics.ControllerMeter;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.metrics.ControllerTimer;
+import org.apache.pinot.spi.utils.retry.RetryPolicy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class IdealStateGroupCommit {
+ private static final Logger LOGGER = LoggerFactory.getLogger(IdealStateGroupCommit.class);
+
+ private static final int NUM_PARTITIONS_THRESHOLD_TO_ENABLE_COMPRESSION = 1000;
+ private static final String ENABLE_COMPRESSIONS_KEY = "enableCompression";
+
+ private static int _minNumCharsInISToTurnOnCompression = -1;
+
+ private static class Queue {
+ final AtomicReference<Thread> _running = new AtomicReference<Thread>();
+ final ConcurrentLinkedQueue<Entry> _pending = new ConcurrentLinkedQueue<Entry>();
+ }
+
+ private static class Entry {
+ final String _resourceName;
+ final Function<IdealState, IdealState> _updater;
+ AtomicBoolean _sent = new AtomicBoolean(false);
+
+ Entry(String resourceName, Function<IdealState, IdealState> updater) {
+ _resourceName = resourceName;
+ _updater = updater;
+ }
+ }
+
+ private final Queue[] _queues = new Queue[100];
+
+ /**
+ * Set up a group committer and its associated queues
+ */
+ public IdealStateGroupCommit() {
+ // Don't use Arrays.fill();
+ for (int i = 0; i < _queues.length; i++) {
+ _queues[i] = new Queue();
+ }
+ }
+
+ private Queue getQueue(String resourceName) {
+ return _queues[(resourceName.hashCode() & Integer.MAX_VALUE) % _queues.length];
+ }
+
+ public static synchronized void setMinNumCharsInISToTurnOnCompression(int minNumChars) {
+ _minNumCharsInISToTurnOnCompression = minNumChars;
+ }
+
+ /**
+ * Do a group update for idealState associated with a given resource key
+ * @param helixManager helixManager with the ability to pull from the current data\
+ * @param resourceName the resource name to be updated
+ * @param updater the idealState updater to be applied
+ * @return true if successful, false otherwise
+ */
+ public ObjectBooleanPair<IdealState> commit(HelixManager helixManager, String resourceName,
+ Function<IdealState, IdealState> updater, RetryPolicy retryPolicy, boolean noChangeOk) {
+ Queue queue = getQueue(resourceName);
+ Entry entry = new Entry(resourceName, updater);
+
+ boolean success = true;
+ queue._pending.add(entry);
+ IdealState finalIdealState = null;
+ while (!entry._sent.get()) {
+ if (queue._running.compareAndSet(null, Thread.currentThread())) {
+ ArrayList<Entry> processed = new ArrayList<>();
+ try {
+ if (queue._pending.peek() == null) {
+ return new ObjectBooleanImmutablePair<>(finalIdealState, true);
+ }
+ // remove from queue
+ Entry first = queue._pending.poll();
+ processed.add(first);
+ String mergedResourceName = first._resourceName;
+ HelixDataAccessor dataAccessor = helixManager.getHelixDataAccessor();
+ PropertyKey idealStateKey = dataAccessor.keyBuilder().idealStates(resourceName);
+ IdealState idealState = dataAccessor.getProperty(idealStateKey);
+
+ // Make a copy of the idealState above to pass it to the updater
+ // NOTE: new IdealState(idealState.getRecord()) does not work because it's shallow copy for map fields and
+ // list fields
+ IdealState idealStateCopy = HelixHelper.cloneIdealState(idealState);
+
+ /**
+ * If the local cache does not contain a value, need to check if there is a
+ * value in ZK; use it as initial value if exists
+ */
+ IdealState updatedIdealState = first._updater.apply(idealStateCopy);
+ Iterator<Entry> it = queue._pending.iterator();
+ while (it.hasNext()) {
+ Entry ent = it.next();
+ if (!ent._resourceName.equals(mergedResourceName)) {
+ continue;
+ }
+ processed.add(ent);
+ updatedIdealState = ent._updater.apply(idealStateCopy);
+ // System.out.println("After merging:" + merged);
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #13976:
URL: https://github.com/apache/pinot/pull/13976#discussion_r1759738456
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils.helix;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.helix.AccessOption;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.PropertyKey;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.helix.zookeeper.zkclient.exception.ZkBadVersionException;
+import org.apache.pinot.common.metrics.ControllerMeter;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.metrics.ControllerTimer;
+import org.apache.pinot.spi.utils.retry.RetryPolicy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class IdealStateGroupCommit {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #13976:
URL: https://github.com/apache/pinot/pull/13976#issuecomment-2343053302
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13976?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `8.14815%` with `124 lines` in your changes missing coverage. Please review.
> Project coverage is 40.58%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0bd3064`)](https://app.codecov.io/gh/apache/pinot/commit/0bd30642a523d8ae3091d1213d1ea25ffc8acc57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1018 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/13976?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...inot/common/utils/helix/IdealStateGroupCommit.java](https://app.codecov.io/gh/apache/pinot/pull/13976?src=pr&el=tree&filepath=pinot-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcommon%2Futils%2Fhelix%2FIdealStateGroupCommit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvSWRlYWxTdGF0ZUdyb3VwQ29tbWl0LmphdmE=) | 7.63% | [121 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/13976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...g/apache/pinot/common/utils/helix/HelixHelper.java](https://app.codecov.io/gh/apache/pinot/pull/13976?src=pr&el=tree&filepath=pinot-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcommon%2Futils%2Fhelix%2FHelixHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvSGVsaXhIZWxwZXIuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/13976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (59551e4) and HEAD (0bd3064). Click for more details.
>
> <details><summary>HEAD has 48 uploads less than BASE</summary>
>
>| Flag | BASE (59551e4) | HEAD (0bd3064) |
>|------|------|------|
>|integration|7|0|
>|integration2|3|0|
>|temurin|12|2|
>|java-21|7|2|
>|skip-bytebuffers-true|3|1|
>|skip-bytebuffers-false|7|1|
>|unittests|5|2|
>|java-11|5|0|
>|unittests2|3|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #13976 +/- ##
=============================================
- Coverage 61.75% 40.58% -21.18%
- Complexity 207 1133 +926
=============================================
Files 2436 1982 -454
Lines 133233 105290 -27943
Branches 20636 16788 -3848
=============================================
- Hits 82274 42727 -39547
- Misses 44911 59153 +14242
+ Partials 6048 3410 -2638
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.58% <8.14%> (-21.05%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.56% <8.14%> (-21.18%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.53% <8.14%> (+12.80%)` | :arrow_up: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.58% <8.14%> (-21.18%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.58% <8.14%> (-21.17%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.58% <8.14%> (-6.32%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/13976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/13976?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "KKcorps (via GitHub)" <gi...@apache.org>.
KKcorps commented on code in PR #13976:
URL: https://github.com/apache/pinot/pull/13976#discussion_r1753527635
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -0,0 +1,298 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils.helix;
+
+import it.unimi.dsi.fastutil.objects.ObjectBooleanImmutablePair;
+import it.unimi.dsi.fastutil.objects.ObjectBooleanPair;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.helix.AccessOption;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.PropertyKey;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.helix.zookeeper.zkclient.exception.ZkBadVersionException;
+import org.apache.pinot.common.metrics.ControllerMeter;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.metrics.ControllerTimer;
+import org.apache.pinot.spi.utils.retry.RetryPolicy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class IdealStateGroupCommit {
+ private static final Logger LOGGER = LoggerFactory.getLogger(IdealStateGroupCommit.class);
+
+ private static final int NUM_PARTITIONS_THRESHOLD_TO_ENABLE_COMPRESSION = 1000;
+ private static final String ENABLE_COMPRESSIONS_KEY = "enableCompression";
+
+ private static int _minNumCharsInISToTurnOnCompression = -1;
+
+ private static class Queue {
+ final AtomicReference<Thread> _running = new AtomicReference<Thread>();
+ final ConcurrentLinkedQueue<Entry> _pending = new ConcurrentLinkedQueue<Entry>();
+ }
+
+ private static class Entry {
+ final String _resourceName;
+ final Function<IdealState, IdealState> _updater;
+ AtomicBoolean _sent = new AtomicBoolean(false);
+
+ Entry(String resourceName, Function<IdealState, IdealState> updater) {
+ _resourceName = resourceName;
+ _updater = updater;
+ }
+ }
+
+ private final Queue[] _queues = new Queue[100];
+
+ /**
+ * Set up a group committer and its associated queues
+ */
+ public IdealStateGroupCommit() {
+ // Don't use Arrays.fill();
+ for (int i = 0; i < _queues.length; i++) {
+ _queues[i] = new Queue();
+ }
+ }
+
+ private Queue getQueue(String resourceName) {
+ return _queues[(resourceName.hashCode() & Integer.MAX_VALUE) % _queues.length];
+ }
+
+ public static synchronized void setMinNumCharsInISToTurnOnCompression(int minNumChars) {
+ _minNumCharsInISToTurnOnCompression = minNumChars;
+ }
+
+ /**
+ * Do a group update for idealState associated with a given resource key
+ * @param helixManager helixManager with the ability to pull from the current data\
+ * @param resourceName the resource name to be updated
+ * @param updater the idealState updater to be applied
+ * @return true if successful, false otherwise
+ */
+ public ObjectBooleanPair<IdealState> commit(HelixManager helixManager, String resourceName,
+ Function<IdealState, IdealState> updater, RetryPolicy retryPolicy, boolean noChangeOk) {
+ Queue queue = getQueue(resourceName);
+ Entry entry = new Entry(resourceName, updater);
+
+ boolean success = true;
+ queue._pending.add(entry);
+ IdealState finalIdealState = null;
+ while (!entry._sent.get()) {
+ if (queue._running.compareAndSet(null, Thread.currentThread())) {
+ ArrayList<Entry> processed = new ArrayList<>();
+ try {
+ if (queue._pending.peek() == null) {
+ return new ObjectBooleanImmutablePair<>(finalIdealState, true);
+ }
+ // remove from queue
+ Entry first = queue._pending.poll();
+ processed.add(first);
+ String mergedResourceName = first._resourceName;
+ HelixDataAccessor dataAccessor = helixManager.getHelixDataAccessor();
+ PropertyKey idealStateKey = dataAccessor.keyBuilder().idealStates(resourceName);
+ IdealState idealState = dataAccessor.getProperty(idealStateKey);
+
+ // Make a copy of the idealState above to pass it to the updater
+ // NOTE: new IdealState(idealState.getRecord()) does not work because it's shallow copy for map fields and
+ // list fields
+ IdealState idealStateCopy = HelixHelper.cloneIdealState(idealState);
+
+ /**
+ * If the local cache does not contain a value, need to check if there is a
+ * value in ZK; use it as initial value if exists
+ */
+ IdealState updatedIdealState = first._updater.apply(idealStateCopy);
+ Iterator<Entry> it = queue._pending.iterator();
+ while (it.hasNext()) {
+ Entry ent = it.next();
+ if (!ent._resourceName.equals(mergedResourceName)) {
+ continue;
+ }
+ processed.add(ent);
+ updatedIdealState = ent._updater.apply(idealStateCopy);
+ // System.out.println("After merging:" + merged);
+ it.remove();
Review Comment:
Is it safe to modify the queue here while we are iterating on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #13976:
URL: https://github.com/apache/pinot/pull/13976#discussion_r1756107098
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils.helix;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.helix.AccessOption;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.PropertyKey;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.helix.zookeeper.zkclient.exception.ZkBadVersionException;
+import org.apache.pinot.common.metrics.ControllerMeter;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.metrics.ControllerTimer;
+import org.apache.pinot.spi.utils.retry.RetryPolicy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class IdealStateGroupCommit {
Review Comment:
Consider putting some comments so that we can trace back to Helix code?
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils.helix;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.helix.AccessOption;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.PropertyKey;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.helix.zookeeper.zkclient.exception.ZkBadVersionException;
+import org.apache.pinot.common.metrics.ControllerMeter;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.metrics.ControllerTimer;
+import org.apache.pinot.spi.utils.retry.RetryPolicy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class IdealStateGroupCommit {
+ private static final Logger LOGGER = LoggerFactory.getLogger(IdealStateGroupCommit.class);
+
+ private static final int NUM_PARTITIONS_THRESHOLD_TO_ENABLE_COMPRESSION = 1000;
+ private static final String ENABLE_COMPRESSIONS_KEY = "enableCompression";
+
+ private static int _minNumCharsInISToTurnOnCompression = -1;
+
+ private static class Queue {
+ final AtomicReference<Thread> _running = new AtomicReference<Thread>();
+ final ConcurrentLinkedQueue<Entry> _pending = new ConcurrentLinkedQueue<Entry>();
+ }
+
+ private static class Entry {
+ final String _resourceName;
+ final Function<IdealState, IdealState> _updater;
+ AtomicBoolean _sent = new AtomicBoolean(false);
+
+ Entry(String resourceName, Function<IdealState, IdealState> updater) {
+ _resourceName = resourceName;
+ _updater = updater;
+ }
+ }
+
+ private final Queue[] _queues = new Queue[100];
+
+ /**
+ * Set up a group committer and its associated queues
+ */
+ public IdealStateGroupCommit() {
+ // Don't use Arrays.fill();
+ for (int i = 0; i < _queues.length; i++) {
+ _queues[i] = new Queue();
+ }
+ }
+
+ private Queue getQueue(String resourceName) {
+ return _queues[(resourceName.hashCode() & Integer.MAX_VALUE) % _queues.length];
+ }
+
+ public static synchronized void setMinNumCharsInISToTurnOnCompression(int minNumChars) {
+ _minNumCharsInISToTurnOnCompression = minNumChars;
+ }
+
+ /**
+ * Do a group update for idealState associated with a given resource key
+ * @param helixManager helixManager with the ability to pull from the current data\
+ * @param resourceName the resource name to be updated
+ * @param updater the idealState updater to be applied
+ * @return true if successful, false otherwise
+ */
+ public boolean commit(HelixManager helixManager, String resourceName,
Review Comment:
We should be able to achieve that by modifying the `_sent` in `Entry` to store the updated IS
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils.helix;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.helix.AccessOption;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.PropertyKey;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.helix.zookeeper.zkclient.exception.ZkBadVersionException;
+import org.apache.pinot.common.metrics.ControllerMeter;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.metrics.ControllerTimer;
+import org.apache.pinot.spi.utils.retry.RetryPolicy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class IdealStateGroupCommit {
+ private static final Logger LOGGER = LoggerFactory.getLogger(IdealStateGroupCommit.class);
+
+ private static final int NUM_PARTITIONS_THRESHOLD_TO_ENABLE_COMPRESSION = 1000;
+ private static final String ENABLE_COMPRESSIONS_KEY = "enableCompression";
+
+ private static int _minNumCharsInISToTurnOnCompression = -1;
+
+ private static class Queue {
+ final AtomicReference<Thread> _running = new AtomicReference<Thread>();
+ final ConcurrentLinkedQueue<Entry> _pending = new ConcurrentLinkedQueue<Entry>();
+ }
+
+ private static class Entry {
+ final String _resourceName;
+ final Function<IdealState, IdealState> _updater;
+ AtomicBoolean _sent = new AtomicBoolean(false);
+
+ Entry(String resourceName, Function<IdealState, IdealState> updater) {
+ _resourceName = resourceName;
+ _updater = updater;
+ }
+ }
+
+ private final Queue[] _queues = new Queue[100];
+
+ /**
+ * Set up a group committer and its associated queues
+ */
+ public IdealStateGroupCommit() {
+ // Don't use Arrays.fill();
+ for (int i = 0; i < _queues.length; i++) {
+ _queues[i] = new Queue();
+ }
+ }
+
+ private Queue getQueue(String resourceName) {
+ return _queues[(resourceName.hashCode() & Integer.MAX_VALUE) % _queues.length];
+ }
+
+ public static synchronized void setMinNumCharsInISToTurnOnCompression(int minNumChars) {
+ _minNumCharsInISToTurnOnCompression = minNumChars;
+ }
+
+ /**
+ * Do a group update for idealState associated with a given resource key
+ * @param helixManager helixManager with the ability to pull from the current data\
+ * @param resourceName the resource name to be updated
+ * @param updater the idealState updater to be applied
+ * @return true if successful, false otherwise
+ */
+ public boolean commit(HelixManager helixManager, String resourceName,
Review Comment:
Shall we keep the existing behavior by returning the updated IS, or throw exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #13976:
URL: https://github.com/apache/pinot/pull/13976#issuecomment-2350996760
> LGTM. Can you double check the existing logic and ensure there is nothing rely on only the current update being processed? If there are, we can consider providing 2 fashions, one allow batching and one does not
I think all the logics using commit method are moved this this sync best-effort kind of commit logic. I would say this is always better than the single commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #13976:
URL: https://github.com/apache/pinot/pull/13976#discussion_r1753856067
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -0,0 +1,298 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils.helix;
+
+import it.unimi.dsi.fastutil.objects.ObjectBooleanImmutablePair;
+import it.unimi.dsi.fastutil.objects.ObjectBooleanPair;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.helix.AccessOption;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.PropertyKey;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.helix.zookeeper.zkclient.exception.ZkBadVersionException;
+import org.apache.pinot.common.metrics.ControllerMeter;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.metrics.ControllerTimer;
+import org.apache.pinot.spi.utils.retry.RetryPolicy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class IdealStateGroupCommit {
+ private static final Logger LOGGER = LoggerFactory.getLogger(IdealStateGroupCommit.class);
+
+ private static final int NUM_PARTITIONS_THRESHOLD_TO_ENABLE_COMPRESSION = 1000;
+ private static final String ENABLE_COMPRESSIONS_KEY = "enableCompression";
+
+ private static int _minNumCharsInISToTurnOnCompression = -1;
+
+ private static class Queue {
+ final AtomicReference<Thread> _running = new AtomicReference<Thread>();
+ final ConcurrentLinkedQueue<Entry> _pending = new ConcurrentLinkedQueue<Entry>();
+ }
+
+ private static class Entry {
+ final String _resourceName;
+ final Function<IdealState, IdealState> _updater;
+ AtomicBoolean _sent = new AtomicBoolean(false);
+
+ Entry(String resourceName, Function<IdealState, IdealState> updater) {
+ _resourceName = resourceName;
+ _updater = updater;
+ }
+ }
+
+ private final Queue[] _queues = new Queue[100];
+
+ /**
+ * Set up a group committer and its associated queues
+ */
+ public IdealStateGroupCommit() {
+ // Don't use Arrays.fill();
+ for (int i = 0; i < _queues.length; i++) {
+ _queues[i] = new Queue();
+ }
+ }
+
+ private Queue getQueue(String resourceName) {
+ return _queues[(resourceName.hashCode() & Integer.MAX_VALUE) % _queues.length];
+ }
+
+ public static synchronized void setMinNumCharsInISToTurnOnCompression(int minNumChars) {
+ _minNumCharsInISToTurnOnCompression = minNumChars;
+ }
+
+ /**
+ * Do a group update for idealState associated with a given resource key
+ * @param helixManager helixManager with the ability to pull from the current data\
+ * @param resourceName the resource name to be updated
+ * @param updater the idealState updater to be applied
+ * @return true if successful, false otherwise
+ */
+ public ObjectBooleanPair<IdealState> commit(HelixManager helixManager, String resourceName,
+ Function<IdealState, IdealState> updater, RetryPolicy retryPolicy, boolean noChangeOk) {
+ Queue queue = getQueue(resourceName);
+ Entry entry = new Entry(resourceName, updater);
+
+ boolean success = true;
+ queue._pending.add(entry);
+ IdealState finalIdealState = null;
+ while (!entry._sent.get()) {
+ if (queue._running.compareAndSet(null, Thread.currentThread())) {
+ ArrayList<Entry> processed = new ArrayList<>();
+ try {
+ if (queue._pending.peek() == null) {
+ return new ObjectBooleanImmutablePair<>(finalIdealState, true);
+ }
+ // remove from queue
+ Entry first = queue._pending.poll();
+ processed.add(first);
+ String mergedResourceName = first._resourceName;
+ HelixDataAccessor dataAccessor = helixManager.getHelixDataAccessor();
+ PropertyKey idealStateKey = dataAccessor.keyBuilder().idealStates(resourceName);
+ IdealState idealState = dataAccessor.getProperty(idealStateKey);
+
+ // Make a copy of the idealState above to pass it to the updater
+ // NOTE: new IdealState(idealState.getRecord()) does not work because it's shallow copy for map fields and
+ // list fields
+ IdealState idealStateCopy = HelixHelper.cloneIdealState(idealState);
+
+ /**
+ * If the local cache does not contain a value, need to check if there is a
+ * value in ZK; use it as initial value if exists
+ */
+ IdealState updatedIdealState = first._updater.apply(idealStateCopy);
+ Iterator<Entry> it = queue._pending.iterator();
+ while (it.hasNext()) {
+ Entry ent = it.next();
+ if (!ent._resourceName.equals(mergedResourceName)) {
+ continue;
+ }
+ processed.add(ent);
+ updatedIdealState = ent._updater.apply(idealStateCopy);
+ // System.out.println("After merging:" + merged);
+ it.remove();
Review Comment:
yes, this is processed in single thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #13976:
URL: https://github.com/apache/pinot/pull/13976#discussion_r1759738444
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils.helix;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Function;
+import org.apache.helix.AccessOption;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.PropertyKey;
+import org.apache.helix.model.IdealState;
+import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import org.apache.helix.zookeeper.zkclient.exception.ZkBadVersionException;
+import org.apache.pinot.common.metrics.ControllerMeter;
+import org.apache.pinot.common.metrics.ControllerMetrics;
+import org.apache.pinot.common.metrics.ControllerTimer;
+import org.apache.pinot.spi.utils.retry.RetryPolicy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class IdealStateGroupCommit {
+ private static final Logger LOGGER = LoggerFactory.getLogger(IdealStateGroupCommit.class);
+
+ private static final int NUM_PARTITIONS_THRESHOLD_TO_ENABLE_COMPRESSION = 1000;
+ private static final String ENABLE_COMPRESSIONS_KEY = "enableCompression";
+
+ private static int _minNumCharsInISToTurnOnCompression = -1;
+
+ private static class Queue {
+ final AtomicReference<Thread> _running = new AtomicReference<Thread>();
+ final ConcurrentLinkedQueue<Entry> _pending = new ConcurrentLinkedQueue<Entry>();
+ }
+
+ private static class Entry {
+ final String _resourceName;
+ final Function<IdealState, IdealState> _updater;
+ AtomicBoolean _sent = new AtomicBoolean(false);
+
+ Entry(String resourceName, Function<IdealState, IdealState> updater) {
+ _resourceName = resourceName;
+ _updater = updater;
+ }
+ }
+
+ private final Queue[] _queues = new Queue[100];
+
+ /**
+ * Set up a group committer and its associated queues
+ */
+ public IdealStateGroupCommit() {
+ // Don't use Arrays.fill();
+ for (int i = 0; i < _queues.length; i++) {
+ _queues[i] = new Queue();
+ }
+ }
+
+ private Queue getQueue(String resourceName) {
+ return _queues[(resourceName.hashCode() & Integer.MAX_VALUE) % _queues.length];
+ }
+
+ public static synchronized void setMinNumCharsInISToTurnOnCompression(int minNumChars) {
+ _minNumCharsInISToTurnOnCompression = minNumChars;
+ }
+
+ /**
+ * Do a group update for idealState associated with a given resource key
+ * @param helixManager helixManager with the ability to pull from the current data\
+ * @param resourceName the resource name to be updated
+ * @param updater the idealState updater to be applied
+ * @return true if successful, false otherwise
+ */
+ public boolean commit(HelixManager helixManager, String resourceName,
Review Comment:
added a new entry to keep this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Group commit IdealState updates [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #13976:
URL: https://github.com/apache/pinot/pull/13976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org