[jira] [Resolved] (AIRFLOW-1393) Enable Python3 tests on contrib Spark Submit Hook

["Bolke de Bruin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AIRFLOW-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bolke de Bruin resolved AIRFLOW-1393.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.3

Issue resolved by pull request #2427
[https://github.com/apache/incubator-airflow/pull/2427]

> Enable Python3 tests on contrib Spark Submit Hook
> -------------------------------------------------
>
>                 Key: AIRFLOW-1393
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1393
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: tests
>            Reporter: Ash Berlin-Taylor
>            Priority: Minor
>             Fix For: 1.8.3
>
>
> The unit tests in {{tests/contrib/hooks/test_spark_submit_hook.py}} currently skip if run in Python3 because some test cases  loop forever due to a mismatch/misunderstanding about bytes vs string (i.e. the mocked data for {{subprocess.Popen}} doesn't behave the same as actually running Popen)
> The fix is to use bytes and {{six.ByteIO}} so that the tests work on Py2 and Py3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)