You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "sdhzwc (via GitHub)" <gi...@apache.org> on 2024/11/05 09:35:19 UTC

[I] [Improvement][Parameter] The field "operator" should be renamed to "modify_user_id" and a default value should be added [dolphinscheduler]

sdhzwc opened a new issue, #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   1、The field "operator" should be renamed to "modify_user_id",Express the meaning more directly
   2、Reference the last_modify_user/last_modify_time in aws/linux,modify_user_id added default value 
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-80] Rename field `operator` to `modify_user_id` [dolphinscheduler]

Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on issue #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772#issuecomment-2461190364

   #16515 In fact, the ideas are similar. Whether to make changes can be discussed, and the operation can be postponed if there is not enough support. What do you think?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-80] Rename field `operator` to `modify_user_id` [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on issue #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772#issuecomment-2461245468

   > In fact, the ideas are similar. Whether to make changes can be discussed, 和 the operation can be postponed if there is not enough support. What do you think?
   This isn't similar to https://github.com/apache/dolphinscheduler/issues/16515, https://github.com/apache/dolphinscheduler/issues/16515 has been discussed  a long time ago, it is not a simple rename operation or code style change, It's a conversion of concepts between workflow and process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-80] Rename field `operator` to `modify_user_id` [dolphinscheduler]

Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on issue #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772#issuecomment-2458644482

   > Not all `operator` fields are `modify_user_id`. It may represent the creator. You should distinguish between them.
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-80] Rename field `operator` to `modify_user_id` [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on issue #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772#issuecomment-2458804944

   I don't disagree with this issue, but this kind of change will bring some incompatible changes. Before making any of these kinds of changes to db schema and API schema, need to make a specification firstly, and list all the fields that need to be changes, otherwise this looks very much like a random personal alteration. In the future, if someone think some fields is not suitable, he might submit another pr to change again, will bring an incompatible changes again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-] The field "operator" should be renamed to "modify_user_id" [dolphinscheduler]

Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on issue #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772#issuecomment-2456754324

   > If this is to be optimized, all relevant frontend and backend codes and table field names need to be modified uniformly. You should create an DSIP first.
   Modified
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-] The field "operator" should be renamed to "modify_user_id" [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on issue #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772#issuecomment-2458634314

   Not all `operator` fields are `modify_user_id`. It may represent the creator. You should distinguish between them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement][Parameter] The field "operator" should be renamed to "modify_user_id" and a default value should be added [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on issue #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772#issuecomment-2456704041

   If this is to be optimized, all relevant frontend and backend codes and table field names need to be modified uniformly. You should create an DSIP first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-80] Rename field `operator` to `modify_user_id` [dolphinscheduler]

Posted by "sdhzwc (via GitHub)" <gi...@apache.org>.
sdhzwc commented on issue #16772:
URL: https://github.com/apache/dolphinscheduler/issues/16772#issuecomment-2461190708

   > I don't disagree with this issue, but this kind of change will bring some incompatible changes. Before making any of these kinds of changes to db schema and API schema, need to make a specification firstly, and list all the fields that need to be changes, otherwise this looks very much like a random personal alteration. In the future, if someone think some fields is not suitable, he might submit another pr to change again, will bring an incompatible changes again.
   
   #16515 In fact, the ideas are similar. Whether to make changes can be discussed, 和 the operation can be postponed if there is not enough support. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [DSIP-] Rename field `operator` to `modify_user_id` [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed issue #16772: [DSIP-] Rename field `operator` to `modify_user_id`
URL: https://github.com/apache/dolphinscheduler/issues/16772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org