You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/02 03:23:56 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #10022: [FLINK-14135][hive][orc] Introduce orc ColumnarRow reader for hive connector

JingsongLi commented on a change in pull request #10022: [FLINK-14135][hive][orc] Introduce orc ColumnarRow reader for hive connector
URL: https://github.com/apache/flink/pull/10022#discussion_r352407208
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorTest.java
 ##########
 @@ -95,9 +95,9 @@ public void testDefaultPartitionName() throws Exception {
 		FileSystem fs = defaultPartPath.getFileSystem(hiveConf);
 		assertTrue(fs.exists(defaultPartPath));
 
-		TableImpl flinkTable = (TableImpl) tableEnv.sqlQuery("select * from db1.part order by x");
+		TableImpl flinkTable = (TableImpl) tableEnv.sqlQuery("select y, x from db1.part order by x");
 
 Review comment:
   As far as the status quo is concerned, it is very difficult.
   Because these tests are so slow. If we parameterize this test class, it will be very very slow...(Maybe will cause timeout)
   I think maybe we should have a lightweight HiveCatalog in future. I created a JIRA to track it:
   https://issues.apache.org/jira/browse/FLINK-15003

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services