You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2022/01/17 13:52:00 UTC
[jira] [Commented] (YUNIKORN-1028) move master branches to pseudo versions in go.mod
[ https://issues.apache.org/jira/browse/YUNIKORN-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477223#comment-17477223 ]
Wilfred Spiegelenburg commented on YUNIKORN-1028:
-------------------------------------------------
To keep track so I do not lose it. Simple way to generate the pseudo version that can be used in go.mod using a single command:
{code:java}
TZ=UTC git --no-pager show --quiet --abbrev=12 --date='format-local:%Y%m%d%H%M%S' --format="v0.0.0-%cd-%h"{code}
> move master branches to pseudo versions in go.mod
> -------------------------------------------------
>
> Key: YUNIKORN-1028
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1028
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common, shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
>
> The current go.mod for both the core and the k8shim point to a release tag of our own repositories. This is not correct.
> The master branches should not point to a release tag as they can move while we go through our development process. Go provides the option to use a pseudo version for this and we should stick to that for master as per this comment https://go.dev/ref/mod#pseudo-versions:
> {quote}Pseudo-versions may refer to revisions for which no [semantic version tags|https://go.dev/ref/mod#glos-semantic-version-tag] are available. They may be used to test commits before creating version tags, for example, on a development branch.
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org