You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/06/28 06:38:39 UTC
[PR] chore: add comprehensive test coverage for camel-jbang-plugin-tui [camel]
gnodet opened a new pull request, #24279:
URL: https://github.com/apache/camel/pull/24279
## Summary
_Claude Code on behalf of forgebot_
- Add 8 new test files with **161 test methods** for the `camel-jbang-plugin-tui` module, bringing total test count from 11 to 172
- Widen 3 methods in `ShellPanel.java` from `private` to package-private to enable direct unit testing: `convertRow`, `encodeKeyEvent`, `convertAttrToStyle`
- Covers the module's core utilities and parsers that previously had no test coverage
### New test files
| File | Methods | What it tests |
|------|---------|---------------|
| `ShellPanelTest` | 28 | Terminal buffer→Line conversion, key event encoding, attribute→style mapping |
| `StatusParserTest` | 23 | Integration/trace/message JSON parsing |
| `MonitorContextTest` | 31 | Formatting helpers (since-last, load, memory, bytes, bar), style thresholds, string comparison |
| `TuiHelperTest` | 27 | ANSI stripping/parsing, type name shortening, object-to-long conversion |
| `CamelMonitorParseKeyTest` | 21 | Key string→KeyEvent parsing (chars, modifiers, special keys) |
| `FuzzyFilterTest` | 14 | Fuzzy matching algorithm, highlight positions, filter state management |
| `SearchHighlighterTest` | 12 | Search/highlight term application, find match navigation, escape handling |
| `LoadAvgTest` | 5 | EWMA computation, formatting, steady-state convergence |
### Source change
Only visibility change — no logic modified:
```java
// ShellPanel.java — 3 methods: private static → static (package-private)
static Line convertRow(long[] buf, int offset, int width)
static byte[] encodeKeyEvent(KeyEvent ke)
static Style convertAttrToStyle(long attr)
```
## Test plan
- [x] All 172 tests pass (`mvn test -pl dsl/camel-jbang/camel-jbang-plugin-tui`)
- [x] Code formatted with `mvn formatter:format impsort:sort` (0 changes needed)
- [ ] CI build passes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add comprehensive test coverage for camel-jbang-plugin-tui [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24279:
URL: https://github.com/apache/camel/pull/24279#issuecomment-4825143505
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add comprehensive test coverage for camel-jbang-plugin-tui [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24279:
URL: https://github.com/apache/camel/pull/24279#issuecomment-4825174505
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-plugin-tui`
<details><summary>All tested modules (2 modules)</summary>
- Camel :: JBang :: Plugin :: TUI
- Camel :: Launcher :: Container
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/28314035176)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add comprehensive test coverage for camel-jbang-plugin-tui [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #24279:
URL: https://github.com/apache/camel/pull/24279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org