You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2014/11/04 19:28:06 UTC
Re: Review Request 25211: Delegated feed eviction to the appropriate
Storage implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25211/
-----------------------------------------------------------
(Updated Nov. 4, 2014, 6:28 p.m.)
Review request for Falcon and shwethags.
Repository: falcon-git
Description
-------
Earlier FeedEviction class contained logic for both FileSystemStorage and TableStorage. Corresponding code was being called using an if else. To make the code cleaner and more manageable I moved the code to the appropriate storage class and delegated feed eviction to the appropriate Storage implementation. Needed to add evict method to Storage Interface and make some minor changes here and there.
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/entity/CatalogStorage.java dbb0293
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4532669
common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 012a6e7
common/src/main/java/org/apache/falcon/entity/Storage.java af3040b
common/src/main/java/org/apache/falcon/retention/EvictionHelper.java PRE-CREATION
retention/src/main/java/org/apache/falcon/retention/FeedEvictor.java 67ea181
Diff: https://reviews.apache.org/r/25211/diff/
Testing
-------
All FeedEvictor tests passed.
Thanks,
Ajay Yadava
Re: Review Request 25211: Delegated feed eviction to the appropriate
Storage implementation
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25211/#review60096
-----------------------------------------------------------
Ship it!
Ship It!
- Srikanth Sundarrajan
On Nov. 4, 2014, 6:28 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25211/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 6:28 p.m.)
>
>
> Review request for Falcon and shwethags.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Earlier FeedEviction class contained logic for both FileSystemStorage and TableStorage. Corresponding code was being called using an if else. To make the code cleaner and more manageable I moved the code to the appropriate storage class and delegated feed eviction to the appropriate Storage implementation. Needed to add evict method to Storage Interface and make some minor changes here and there.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java dbb0293
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 4532669
> common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 012a6e7
> common/src/main/java/org/apache/falcon/entity/Storage.java af3040b
> common/src/main/java/org/apache/falcon/retention/EvictionHelper.java PRE-CREATION
> retention/src/main/java/org/apache/falcon/retention/FeedEvictor.java 67ea181
>
> Diff: https://reviews.apache.org/r/25211/diff/
>
>
> Testing
> -------
>
> All FeedEvictor tests passed.
>
>
> Thanks,
>
> Ajay Yadava
>
>