You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "lintingbin (via GitHub)" <gi...@apache.org> on 2024/08/19 13:28:15 UTC
[PR] fix: optimize helm script [incubator-streampark]
lintingbin opened a new pull request, #3972:
URL: https://github.com/apache/incubator-streampark/pull/3972
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
1. Remove command: ["bash","-c","bash ./bin/streampark.sh start_docker"] to fix the issue where it cannot start.
2. Add volume-related configurations to facilitate users to insert their own k8s storage configurations.
3. Add TLS-related configurations to ingress.
4. Optimize RBAC configurations by adding edit permissions for the default serviceaccount in the namespace, to prevent permission issues for new users when starting Flink.
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optimize helm script [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #3972:
URL: https://github.com/apache/incubator-streampark/pull/3972#discussion_r1721914497
##########
helm/streampark/templates/streampark.yml:
##########
@@ -60,7 +60,6 @@ spec:
{{- toYaml .Values.spec.container.env | nindent 12 }}
securityContext:
privileged: false
- command: ["bash","-c","bash ./bin/streampark.sh start_docker"]
Review Comment:
Thanks for your clarification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optimize helm script [incubator-streampark]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3972:
URL: https://github.com/apache/incubator-streampark/pull/3972#issuecomment-2296582332
## [](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=3972) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=3972&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_incubator-streampark&pullRequest=3972&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-streampark&pullRequest=3972&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=3972&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_incubator-streampark&pullRequest=3972&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_incubator-streampark&pullRequest=3972)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optimize helm script [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #3972:
URL: https://github.com/apache/incubator-streampark/pull/3972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optimize helm script [incubator-streampark]
Posted by "lintingbin (via GitHub)" <gi...@apache.org>.
lintingbin commented on code in PR #3972:
URL: https://github.com/apache/incubator-streampark/pull/3972#discussion_r1721911426
##########
helm/streampark/templates/streampark.yml:
##########
@@ -60,7 +60,6 @@ spec:
{{- toYaml .Values.spec.container.env | nindent 12 }}
securityContext:
privileged: false
- command: ["bash","-c","bash ./bin/streampark.sh start_docker"]
Review Comment:
Remove command: ["bash","-c","bash ./bin/streampark.sh start_docker"] to fix the issue where it cannot start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optimize helm script [incubator-streampark]
Posted by "lintingbin (via GitHub)" <gi...@apache.org>.
lintingbin commented on code in PR #3972:
URL: https://github.com/apache/incubator-streampark/pull/3972#discussion_r1721909071
##########
helm/streampark/templates/streampark.yml:
##########
@@ -60,7 +60,6 @@ spec:
{{- toYaml .Values.spec.container.env | nindent 12 }}
securityContext:
privileged: false
- command: ["bash","-c","bash ./bin/streampark.sh start_docker"]
Review Comment:
https://github.com/apache/incubator-streampark/blob/dev-2.1.5/docker/Dockerfile#L79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: optimize helm script [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #3972:
URL: https://github.com/apache/incubator-streampark/pull/3972#discussion_r1721899549
##########
helm/streampark/templates/streampark.yml:
##########
@@ -60,7 +60,6 @@ spec:
{{- toYaml .Values.spec.container.env | nindent 12 }}
securityContext:
privileged: false
- command: ["bash","-c","bash ./bin/streampark.sh start_docker"]
Review Comment:
Can you please explain why remove start_docker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org