You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "mattfaltyn (via GitHub)" <gi...@apache.org> on 2026/08/09 22:17:41 UTC
[PR] Preserve setup entity properties in exports [polaris]
mattfaltyn opened a new pull request, #5265:
URL: https://github.com/apache/polaris/pull/5265
## Summary
`polaris setup export` omitted user-defined `properties` from principals and catalog roles even though `setup apply` accepts both fields. Exporting and reapplying a configuration therefore silently discarded that metadata.
This patch:
- preserves non-empty principal and catalog-role properties during export
- adds an export/YAML/apply regression test for both entity types
- documents the supported fields in the reference configuration and setup guide
- records the user-visible fix in the changelog
Fixes #5264
## Validation
- `.venv/bin/pytest tests/test_setup_command.py -q` โ 19 passed, 3 subtests passed
- `make client-unit-test` โ 173 passed
- `make client-lint`
- `make client-build`
- `./gradlew format compileAll` with Java 21
- `./gradlew :polaris-runtime-spark-tests:catalogFederationIntTest --rerun-tasks --max-workers=1`
- `./gradlew check --max-workers=1` with Java 21 and Colima โ 1,409 tasks, build successful
- `site/bin/check-release-doc-links.sh`
## Checklist
- [x] ๐ก๏ธ No security issue is disclosed
- [x] ๐ The need is explained and linked: Fixes #5264
- [x] ๐งช Added export/YAML/apply round-trip coverage and ran the full repository check
- [x] ๐ก No complex logic was introduced
- [x] ๐งพ Updated `CHANGELOG.md`
- [x] ๐ Updated `site/content/in-dev/unreleased`
## AI assistance
AI assistance was used to investigate the issue and prepare the patch. I reviewed the complete diff and validated the implementation end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve setup entity properties in exports [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on PR #5265:
URL: https://github.com/apache/polaris/pull/5265#issuecomment-5248655818
LGTM, thanks for the fix @mattfaltyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve setup entity properties in exports [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5265:
URL: https://github.com/apache/polaris/pull/5265#discussion_r3761736013
##########
CHANGELOG.md:
##########
@@ -133,6 +133,8 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- The NoSQL persistence commit log (`Commits.commitLog`) no longer stops early when a commit's recent-ancestor tail is shorter than the internal fetch page size. With a `polaris.persistence.reference-previous-head-count` smaller than the page size, the natural-order commit log previously truncated at the first short tail because trailing null entries in the fetch page were treated as end-of-history, which could also drop still-referenced objects during maintenance.
- Python CLI REPL now shows a clear "Syntax error" message for malformed input instead of a generic "unexpected error" message.
+- Python CLI `setup export` now preserves user-defined properties on principals and catalog roles,
Review Comment:
thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve setup entity properties in exports [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5265:
URL: https://github.com/apache/polaris/pull/5265#discussion_r3760861847
##########
CHANGELOG.md:
##########
@@ -133,6 +133,8 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- The NoSQL persistence commit log (`Commits.commitLog`) no longer stops early when a commit's recent-ancestor tail is shorter than the internal fetch page size. With a `polaris.persistence.reference-previous-head-count` smaller than the page size, the natural-order commit log previously truncated at the first short tail because trailing null entries in the fetch page were treated as end-of-history, which could also drop still-referenced objects during maintenance.
- Python CLI REPL now shows a clear "Syntax error" message for malformed input instead of a generic "unexpected error" message.
+- Python CLI `setup export` now preserves user-defined properties on principals and catalog roles,
Review Comment:
This should be under the "unreleased" section since the PR is going to merge into `main` (not 1.7.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve setup entity properties in exports [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #5265:
URL: https://github.com/apache/polaris/pull/5265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve setup entity properties in exports [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #5265:
URL: https://github.com/apache/polaris/pull/5265#issuecomment-5256821737
The PR LGTM :+1: @mattfaltyn : Please fix merge conflicts after #5257, sorry about the breakage, but I thought the "main" bulk of changelog adjustments had to merge first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve setup entity properties in exports [polaris]
Posted by "mattfaltyn (via GitHub)" <gi...@apache.org>.
mattfaltyn commented on code in PR #5265:
URL: https://github.com/apache/polaris/pull/5265#discussion_r3761048062
##########
CHANGELOG.md:
##########
@@ -133,6 +133,8 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- The NoSQL persistence commit log (`Commits.commitLog`) no longer stops early when a commit's recent-ancestor tail is shorter than the internal fetch page size. With a `polaris.persistence.reference-previous-head-count` smaller than the page size, the natural-order commit log previously truncated at the first short tail because trailing null entries in the fetch page were treated as end-of-history, which could also drop still-referenced objects during maintenance.
- Python CLI REPL now shows a clear "Syntax error" message for malformed input instead of a generic "unexpected error" message.
+- Python CLI `setup export` now preserves user-defined properties on principals and catalog roles,
Review Comment:
@dimas-b done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org