You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/11 18:23:02 UTC

[GitHub] [cloudstack] weizhouapache opened a new pull request, #6244: kvm: truncate vnc password to 8 chars

weizhouapache opened a new pull request, #6244:
URL: https://github.com/apache/cloudstack/pull/6244

   ### Description
   
   This PR truncates the vnc password of kvm vms to 8 chars.
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1097996786

   <b>Trillian test result (tid-3884)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33260 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3884-kvm-centos7.zip
   Smoke tests completed. 88 look OK, 5 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.56 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 28.83 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 52.20 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 37.91 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 35.95 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 124.61 | test_kubernetes_clusters.py
   test_01_secure_vm_migration | `Error` | 149.24 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 274.11 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 143.78 | test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 43.78 | test_vm_life_cycle.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 8.43 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 8.43 | test_snapshots.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 305.93 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 9.27 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096932213

   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1098000700

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#discussion_r848257086


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1764,7 +1764,7 @@ public String toString() {
                 graphicBuilder.append(" listen=''");
             }
             if (_passwd != null) {
-                graphicBuilder.append(" passwd='" + _passwd + "'");
+                graphicBuilder.append(" passwd='" + StringUtils.truncate(_passwd, 8) + "'");

Review Comment:
   @rohityadavcloud 
   this aims to fix an issue with ubuntu 22.04 (to be released soon) and libvirt 8.
   the issue is raised in mailing list: https://lists.apache.org/thread/zk4fyggjqk1zphk4dfg1m596yrd15d9b
   
   from many years ago, libvirt accepts vnc password with more than 8 chars. but only the first 8 chars in vnc password are used in vnc console verification (the other chars are dropped).
   In recent libvirt, only vnc password with 8 chars is permitted.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096552024

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096319392

   tested on centos7 and ubuntu20, vm console works.
   
   I have not tested on ubuntu 22.04.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1099460153

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1099511344

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096504147

   @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
   
    SystemVM template(s). I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] rohityadavcloud merged pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096573532

   
   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1095873129

   @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1095399818

   this requires manually testing on ubuntu 22.04 or libvirt 8. I will not sure if novnc console works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096573917

   @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
   
    SystemVM template(s). I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1095869889

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1097500171

   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096302145

   @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096301169

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096682994

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096354641

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096600220

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096931031

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1098001807

   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1099461067

   @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1095920870

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096683896

   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#discussion_r848270506


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1764,7 +1764,7 @@ public String toString() {
                 graphicBuilder.append(" listen=''");
             }
             if (_passwd != null) {
-                graphicBuilder.append(" passwd='" + _passwd + "'");
+                graphicBuilder.append(" passwd='" + StringUtils.truncate(_passwd, 8) + "'");

Review Comment:
   LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#discussion_r848202726


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1764,7 +1764,7 @@ public String toString() {
                 graphicBuilder.append(" listen=''");
             }
             if (_passwd != null) {
-                graphicBuilder.append(" passwd='" + _passwd + "'");
+                graphicBuilder.append(" passwd='" + StringUtils.truncate(_passwd, 8) + "'");

Review Comment:
   Why is that @weizhouapache ? Does this fix/address any libvirt limitation or user reported issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096497175

   
   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1097499988

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1097443712

   <b>Trillian test result (tid-3879)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30158 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3879-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1096696151

   <b>Trillian Build Failed (tid-3871)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6244: kvm: truncate vnc password to 8 chars

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#issuecomment-1098531472

   <b>Trillian test result (tid-3895)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32789 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3895-kvm-centos7.zip
   Smoke tests completed. 93 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org