You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "slilichenko (via GitHub)" <gi...@apache.org> on 2023/06/02 15:31:34 UTC

[GitHub] [beam] slilichenko commented on a diff in pull request #26975: Add upsert and delete support to BigQueryIO

slilichenko commented on code in PR #26975:
URL: https://github.com/apache/beam/pull/26975#discussion_r1214530192


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -3068,6 +3148,17 @@ public WriteResult expand(PCollection<T> input) {
             !getAutoSchemaUpdate(),
             "withAutoSchemaUpdate only supported when using storage-api writes.");
       }
+      if (getRowUpdateFn() != null) {
+        if (method != Method.STORAGE_API_AT_LEAST_ONCE) {

Review Comment:
   Why not "checkArgument(method == STORAGE_API_AT_LEAST_ONCE)" instead of if and check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org