You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/04 18:53:56 UTC
[GitHub] [superset] junlincc opened a new issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
junlincc opened a new issue #12952:
URL: https://github.com/apache/superset/issues/12952
I connected to multiple different db for testing purposes. I wanted to test datasets that are from a presto, but had a hard time looking for it by name. there is no way to search by "type", "schema","connection" and "creator" currently.
proposed change - allow user to search by all column.
<img width="1556" alt="Screen Shot 2021-02-04 at 10 29 09 AM" src="https://user-images.githubusercontent.com/67837651/106938428-d6095300-66d3-11eb-87c0-0b1b8440c903.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12952:
URL: https://github.com/apache/superset/issues/12952#issuecomment-816286319
https://github.com/apache/superset/tree/master/superset-frontend/src/datasource please see link @ankh6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #12952:
URL: https://github.com/apache/superset/issues/12952#issuecomment-815999721
Feel free to dig into the code. You'll know the answer when you see how current component is implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12952:
URL: https://github.com/apache/superset/issues/12952#issuecomment-810582215
@ankh6 thank you for picking up the task!
@ktmud can you help answer these technical questions ^^ 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #12952:
URL: https://github.com/apache/superset/issues/12952#issuecomment-815999721
Feel free to dig into the code. You'll know the answer when you see how current component is implemented. @ankh6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #12952:
URL: https://github.com/apache/superset/issues/12952#issuecomment-816383569
> Hey @junlincc !
> I'd like to work on this issue if possible. Could you clarify these points:
>
> * Does this task also involve frontend work ?
>
> * Which modules are involved ?
>
> * Should we implement as a @classmethod in a base class so that we can search irregardless of the database?
Hi, there.
It is a frontend work, please explore the codebase here.
https://github.com/apache/superset/blob/a3b41e2bac554a097015cf73e950ca1fc5e43b6e/superset-frontend/src/datasource/ChangeDatasourceModal.tsx#L99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12952:
URL: https://github.com/apache/superset/issues/12952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ankh6 commented on issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
Posted by GitBox <gi...@apache.org>.
ankh6 commented on issue #12952:
URL: https://github.com/apache/superset/issues/12952#issuecomment-810511844
Hey @junlincc !
I'd like to work on this issue if possible. Could you clarify these points:
- Does this task also involve frontend work ?
- Which modules are involved ?
- Should we implement as a @classmethod in a base class so that we can search irregardless of the database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ankh6 commented on issue #12952: [explore]allow users to search "type""schema"'connection""creator" in Change dataset
Posted by GitBox <gi...@apache.org>.
ankh6 commented on issue #12952:
URL: https://github.com/apache/superset/issues/12952#issuecomment-815174588
@junlincc any news :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org