You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/09/27 11:04:00 UTC

[GitHub] [systemds] atefeh-asayesh opened a new pull request #1402: Builtin header2

atefeh-asayesh opened a new pull request #1402:
URL: https://github.com/apache/systemds/pull/1402


   In this PR we add missing Builtin Function Header for all the script/builtin Functions, Specifically, add a header to each such
   builtin dml file with a brief summary, input parameters, and outputs.
   In order to make the PR not too large I split this task into 2 PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] j143 edited a comment on pull request #1402: Builtin header2

Posted by GitBox <gi...@apache.org>.
j143 edited a comment on pull request #1402:
URL: https://github.com/apache/systemds/pull/1402#issuecomment-978081200


   Hi, @atefeh-asayesh !
   
   ~~It would difficult to handle lots of files. As a starting point, just change only one file, get it reviewed and merged.
   then slowly increase the number of files.~~
   
   I just got to know that you were advised for a bigger PR. Please ignore my previous comments.
   
   Best,
   Janardhan


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard closed pull request #1402: Builtin header2

Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1402:
URL: https://github.com/apache/systemds/pull/1402


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] j143 commented on pull request #1402: Builtin header2

Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1402:
URL: https://github.com/apache/systemds/pull/1402#issuecomment-978081200


   Hi, @atefeh-asayesh !
   
   It would difficult to handle lots of files. As a starting point, just change only one file, get it reviewed and merged.
   then slowly increase the number of files.
   
   Best,
   Janardhan


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1402: Builtin header2

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1402:
URL: https://github.com/apache/systemds/pull/1402#issuecomment-1002211298


   Closing because i am merging in other PR #1492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org