You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2015/11/17 12:49:30 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1076
CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load
For setting the width of each data item for each row of Port Forwarding rules, it was processing all rules.
Basically for each data item, it was searching in all rules, which is un-necessary.
If there are N-Rules, It was processing N-times.
Now, it only processes one time by taking all N-rules at a time.
The previous solution was of O(NxN). Now its changed to O(N).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-maharana/cloudstack CloudStack-Nitin13
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1076
----
commit 3aa63dc76ac1869d62ce42d8e5dc2752ebe71601
Author: Nitin Kumar Maharana <ni...@gmail.com>
Date: 2015-11-17T11:57:26Z
CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load
For setting the width of each data item for each row of portforwarding rules, it was processing all rules.
Basically for each data item, it was searching in all rules, which is un-necessary.
If there are N-Rules, It was processing N-times.
Now, it only processes one time by taking all N-rules at a time.
The previous solution was of O(NxN). Now its changed to O(N).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157409637
Hi @nitin-maharana thanks for the fix! Please make this pull request against 4.6, so it can be fixed there as well. Once merged, it will be forward merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1076#discussion_r45052092
--- Diff: ui/scripts/ui/widgets/multiEdit.js ---
@@ -279,7 +279,7 @@
}
// Align width to main header
- _medit.refreshItemWidths($multi);
+ //_medit.refreshItemWidths($multi);
--- End diff --
can you delete code instead of commenting out, please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1076#discussion_r45074032
--- Diff: ui/scripts/ui/widgets/multiEdit.js ---
@@ -279,7 +279,7 @@
}
// Align width to main header
- _medit.refreshItemWidths($multi);
+ //_medit.refreshItemWidths($multi);
--- End diff --
Sure @DaanHoogland. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157440647
Hi @remibergsma
Actually 4.6 is nine commits behind this branch. So I am making one more pull request with different branch. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157498727
@nitin-maharana You can close this one. When the 4.6 one is merged, it will be forwarded merged to master automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---