You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/26 03:56:57 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10202: Remove time_bucket tag for BanyanDB impl

wu-sheng commented on code in PR #10202:
URL: https://github.com/apache/skywalking/pull/10202#discussion_r1057050727


##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBConverter.java:
##########
@@ -229,6 +243,9 @@ public StorageToMeasure(MetadataRegistry.Schema schema, DataPoint dataPoint) {
 
         @Override
         public Object get(String fieldName) {
+            if (fieldName.equals(Metrics.TIME_BUCKET)) {

Review Comment:
   `Record` and `Metrics` seem to have duplicated **TIME_BUCKET** fields. I think we need a PR to merge these two into `StorageData`, and use it instead of here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org