You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/31 12:36:59 UTC

[GitHub] [flink] dawidwys opened a new pull request #9297: [FLINK-13504][table] Fixed shading issues in table modules.

dawidwys opened a new pull request #9297: [FLINK-13504][table] Fixed shading issues in table modules.
URL: https://github.com/apache/flink/pull/9297
 
 
   ## What is the purpose of the change
   
   Moved the common calcite specific dependencies configuration to
   flink-table in order to have them unified across flink-table-planner,
   flink-table-planner-blink, flink-table-runtime-blink & flink-sql-parser.
   
   Shading configuration is also done in the table parent pom so that all
   modules have common relocation policies.
   
   Enabled shading for flink-sql-parser.
   
   ## Verifying this change
   
   * For verification of sql-parser module e.g. run the query attached to jira issue.
   * Verify contents of flink-table-planner, flink-table-planner-blink, flink-table-runtime-blink, flink-sql-parser, flink-table-uber, flink-table-uber-blink do not contain unwanted classes.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**yes** / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no /** don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services