You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2010/02/12 00:38:28 UTC

[jira] Created: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

The RPC client should try to re-login when it detects that the TGT expired
--------------------------------------------------------------------------

                 Key: HADOOP-6559
                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
             Project: Hadoop Common
          Issue Type: Improvement
          Components: security
    Affects Versions: 0.22.0
            Reporter: Devaraj Das
            Assignee: Devaraj Das
             Fix For: 0.22.0


Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Attachment: h-6559.5.patch

Ok, here is the patch that addresses the comments Kan/Owen had.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833683#action_12833683 ] 

Hadoop QA commented on HADOOP-6559:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12435829/h-6559.5.patch
  against trunk revision 909806.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/359/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/359/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/359/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/359/console

This message is automatically generated.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833707#action_12833707 ] 

Hudson commented on HADOOP-6559:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #168 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/168/])
    . Makes the RPC client automatically re-login when the SASL connection setup fails. This is applicable only to keytab based logins. Contributed by Devaraj Das.


> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.bp20.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833766#action_12833766 ] 

Hudson commented on HADOOP-6559:
--------------------------------

Integrated in Hadoop-Common-trunk #250 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/250/])
    . Makes the RPC client automatically re-login when the SASL connection setup fails. This is applicable only to keytab based logins. Contributed by Devaraj Das.


> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.bp20.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Attachment: h-6559.2.patch

This is a better version of the same patch.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Attachment: h-6559.1.patch

The attached patch:
1) The RPC client will try to do re-login when it encounters SaslException. The max #tries is 3 with a 5 seconds sleep between the trials.
2) Adds a method in the UGI class to do with relogin, and that uses the same keytab/principal that login was originally called with.
3) The relogin meth keeps track of when it was last run (so as to avoid a flood of such calls, made from different contexts).


> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833098#action_12833098 ] 

Kan Zhang commented on HADOOP-6559:
-----------------------------------

bq. saslRpcClient.saslConnect() needs to be in doAs() block, whereas new SaslRpcClient() may be not.
bq. no need to return SaslRpcClient as it is a member field.
bq. please make sure your change is compatible with HADOOP-6543 (i.e., I'll eventually make saslRpcClient.saslConnect() return boolean based on whether we need to fall back to simple auth).
bq. you need to re-throw SaslException when the retry block is not entered.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833695#action_12833695 ] 

Hadoop QA commented on HADOOP-6559:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12435847/h-6559.6.patch
  against trunk revision 909806.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/360/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/360/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/360/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/360/console

This message is automatically generated.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Status: Patch Available  (was: Open)

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Status: Open  (was: Patch Available)

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Attachment: h-6559.6.bp20.patch

Patch for Y!20. Not for commit here.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.bp20.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.bp20.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Status: Patch Available  (was: Open)

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Attachment: h-6559.3.patch

Fixes to ensure that re-login only happens if the client did a keytab login earlier. Also, overwrites the ticket in the remoteId object with the new ticket that is created with the new Subject.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833694#action_12833694 ] 

Owen O'Malley commented on HADOOP-6559:
---------------------------------------

+1

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833133#action_12833133 ] 

Owen O'Malley commented on HADOOP-6559:
---------------------------------------

I'd suggest instead making the relogin a non-static method on the UGI and have it pass the Subject into the LoginContext. That will mean that it will keep the same UGI and Subject and you can have the retry code inside of the doAs instead of outside of it.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6559:
--------------------------------

    Attachment: h-6559.6.patch

Attaching a patch that fixes the warnings. I also simplified the patch to not do retrials for the re-login but instead the re-login is attempted once (even for a fresh login the attempt is made only once..).

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6559) The RPC client should try to re-login when it detects that the TGT expired

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833696#action_12833696 ] 

Devaraj Das commented on HADOOP-6559:
-------------------------------------

This patch is relevant only to the kerberos setup where i manually tested it. We currently don't have any framework for kerberos junit tests and hence not adding any test here.

> The RPC client should try to re-login when it detects that the TGT expired
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6559
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: h-6559.1.patch, h-6559.2.patch, h-6559.3.patch, h-6559.5.patch, h-6559.6.patch
>
>
> Currently while making RPC calls, the client will throw an exception if the client is not able to use the TGT (expired or timedout). This could be improved - it could catch the exception and try doing a re-login.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.