[GitHub] [celix] pnoltes commented on a change in pull request #325: Feature/utils zip extract

[GitBox <gi...@apache.org>]

pnoltes commented on a change in pull request #325:
URL: https://github.com/apache/celix/pull/325#discussion_r699025031



##########
File path: cmake/Modules/FindLIBZIP.cmake
##########
@@ -0,0 +1,49 @@
+# or more contributor license agreements.  See the NOTICE file

Review comment:
       updated

##########
File path: libs/utils/CMakeLists.txt
##########
@@ -39,12 +41,15 @@ add_library(utils SHARED
     src/ip_utils.c
     src/filter.c
     src/celix_log_utils.c
+    src/celix_file_utils.c
     ${MEMSTREAM_SOURCES}
 )
 set_target_properties(utils PROPERTIES OUTPUT_NAME "celix_utils")
+target_link_libraries(utils PRIVATE libzip::libzip)
 
 if (NOT OPEN_MEMSTREAM_EXISTS)
     target_compile_definitions(utils PUBLIC -DNO_MEMSTREAM_AVAILABLE)
+    target_compile_definitions(utils PUBLIC -DNO_MEMSTREAM_AVAILABLE)

Review comment:
       double line removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org