You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by pietermartin <gi...@git.apache.org> on 2016/03/26 18:20:08 UTC
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
GitHub user pietermartin opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/279
Tinkerpop 968:Add first class support for an optional traversal
https://issues.apache.org/jira/browse/TINKERPOP-968
Added `optional(Traversal)` to `GraphTraversal`. Optional semantics is implemented via the `choose` step.
Added `OptionalTest.java`
Added `Optional`-step documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-968
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #279
----
commit 427c3327988d83970d3191c552357d4805d01e61
Author: pieter <pi...@gmail.com>
Date: 2016-03-25T15:26:45Z
added optional to GraphTraversal
commit 2652bc2516b5408015c8daf30ac69964e3dc0dd2
Author: pieter <pi...@gmail.com>
Date: 2016-03-25T15:58:00Z
Merge branch 'master' into TINKERPOP-968
commit edc9d68234873a56bb148bd958f410d845f339de
Author: pieter <pi...@gmail.com>
Date: 2016-03-25T17:17:30Z
Merge branch 'master' into TINKERPOP-968
commit 0b6c0f41565cfc3578ca6c64447c536c4148fb4a
Author: pieter <pi...@gmail.com>
Date: 2016-03-26T16:54:04Z
Merge branch 'master' into TINKERPOP-968
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203588009
looks like enough votes to merge if @pietermartin votes himself. i'd still like to hear if anyone else can run gremlin server integration tests successfully against this before merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203391062
Can you also check Neo4j? This is the "full integration" test command.
```
mvn clean install -DskipIntegrationTests=false -DincludeNeo4j
```
Given that you already did the `-DskipIntegrationTests`, just do:
```
mvn clean install -DincludeNeo4j
```
Finally, please talk with @spmallette about the `GremlinServerAuth` issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#discussion_r57517467
--- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/OptionalTest.java ---
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.process.traversal.step.branch;
+
+import org.apache.tinkerpop.gremlin.LoadGraphWith;
+import org.apache.tinkerpop.gremlin.process.AbstractGremlinProcessTest;
+import org.apache.tinkerpop.gremlin.process.GremlinProcessRunner;
+import org.apache.tinkerpop.gremlin.process.IgnoreEngine;
+import org.apache.tinkerpop.gremlin.process.traversal.Path;
+import org.apache.tinkerpop.gremlin.process.traversal.Traversal;
+import org.apache.tinkerpop.gremlin.process.traversal.TraversalEngine;
+import org.apache.tinkerpop.gremlin.structure.Vertex;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Optional;
+import java.util.function.Predicate;
+
+import static org.apache.tinkerpop.gremlin.LoadGraphWith.GraphData.MODERN;
+import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.in;
+import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.out;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * @author Pieter Martin
+ */
+@RunWith(GremlinProcessRunner.class)
+public abstract class OptionalTest extends AbstractGremlinProcessTest {
+
+ public abstract Traversal<Vertex, Vertex> get_g_VX2X_optionalXoutXknowsXX(Object v2Id);
+
+ public abstract Traversal<Vertex, Vertex> get_g_VX2X_optionalXinXknowsXX(Object v2Id);
+
+ public abstract Traversal<Vertex, Path> get_g_V_hasLabelXpersonX_optionalXoutXknowsX_optionalXoutXcreatedXXX_path();
+
+ public abstract Traversal<Vertex, Path> get_g_V_optionalXout_optionalXoutXX_path();
+
+ @Test
+ @LoadGraphWith(MODERN)
+ public void g_VX2X_optionalXoutXknowsXX() {
+ final Traversal<Vertex, Vertex> traversal = get_g_VX2X_optionalXoutXknowsXX(convertToVertexId(this.graph, "vadas"));
+ printTraversalForm(traversal);
+ assertTrue(traversal.hasNext());
+ assertEquals(convertToVertex(this.graph, "vadas"), traversal.next());
+ }
+
+ @Test
+ @LoadGraphWith(MODERN)
+ public void g_VX2X_optionalXinXknowsXX() {
+ final Traversal<Vertex, Vertex> traversal = get_g_VX2X_optionalXinXknowsXX(convertToVertexId(this.graph, "vadas"));
+ printTraversalForm(traversal);
+ assertTrue(traversal.hasNext());
+ assertEquals(convertToVertex(this.graph, "marko"), traversal.next());
+ }
+
+ @Test
+ @LoadGraphWith(MODERN)
+ @IgnoreEngine(TraversalEngine.Type.COMPUTER)
+ public void g_V_hasLabelXpersonX_optionalXoutXknowsX_optionalXoutXcreatedXXX_path() {
+ final Traversal<Vertex, Path> traversal = get_g_V_hasLabelXpersonX_optionalXoutXknowsX_optionalXoutXcreatedXXX_path();
+ printTraversalForm(traversal);
+ List<Path> paths = traversal.toList();
+ assertEquals(6, paths.size());
+ List<Predicate<Path>> pathsToAssert = Arrays.asList(
+ p -> p.size() == 2 && p.get(0).equals(convertToVertex(this.graph, "marko")) && p.get(1).equals(convertToVertex(this.graph, "vadas")),
+ p -> p.size() == 3 && p.get(0).equals(convertToVertex(this.graph, "marko")) && p.get(1).equals(convertToVertex(this.graph, "josh")) && p.get(2).equals(convertToVertex(this.graph, "ripple")),
+ p -> p.size() == 3 && p.get(0).equals(convertToVertex(this.graph, "marko")) && p.get(1).equals(convertToVertex(this.graph, "josh")) && p.get(2).equals(convertToVertex(this.graph, "lop")),
+ p -> p.size() == 1 && p.get(0).equals(convertToVertex(this.graph, "vadas")),
+ p -> p.size() == 1 && p.get(0).equals(convertToVertex(this.graph, "josh")),
+ p -> p.size() == 1 && p.get(0).equals(convertToVertex(this.graph, "peter"))
+ );
+ for (Predicate<Path> pathPredicate : pathsToAssert) {
+ Optional<Path> path = paths.stream().filter(pathPredicate).findAny();
+ assertTrue(path.isPresent());
+ assertTrue(paths.remove(path.get()));
+ }
+ assertTrue(paths.isEmpty());
+ }
+
+ @Test
+ @LoadGraphWith(MODERN)
+ @IgnoreEngine(TraversalEngine.Type.COMPUTER)
+ public void g_V_optionalXout_optionalXoutXX_path() {
+ final Traversal<Vertex, Path> traversal = get_g_V_optionalXout_optionalXoutXX_path();
+ printTraversalForm(traversal);
+ List<Path> paths = traversal.toList();
+ assertEquals(10, paths.size());
+ List<Predicate<Path>> pathsToAssert = Arrays.asList(
+ p -> p.size() == 2 && p.get(0).equals(convertToVertex(this.graph, "marko")) && p.get(1).equals(convertToVertex(this.graph, "lop")),
+ p -> p.size() == 2 && p.get(0).equals(convertToVertex(this.graph, "marko")) && p.get(1).equals(convertToVertex(this.graph, "vadas")),
+ p -> p.size() == 3 && p.get(0).equals(convertToVertex(this.graph, "marko")) && p.get(1).equals(convertToVertex(this.graph, "josh")) && p.get(2).equals(convertToVertex(this.graph, "lop")),
+ p -> p.size() == 3 && p.get(0).equals(convertToVertex(this.graph, "marko")) && p.get(1).equals(convertToVertex(this.graph, "josh")) && p.get(2).equals(convertToVertex(this.graph, "ripple")),
+ p -> p.size() == 1 && p.get(0).equals(convertToVertex(this.graph, "vadas")),
+ p -> p.size() == 1 && p.get(0).equals(convertToVertex(this.graph, "lop")),
+ p -> p.size() == 2 && p.get(0).equals(convertToVertex(this.graph, "josh")) && p.get(1).equals(convertToVertex(this.graph, "lop")),
+ p -> p.size() == 2 && p.get(0).equals(convertToVertex(this.graph, "josh")) && p.get(1).equals(convertToVertex(this.graph, "ripple")),
+ p -> p.size() == 1 && p.get(0).equals(convertToVertex(this.graph, "ripple")),
+ p -> p.size() == 2 && p.get(0).equals(convertToVertex(this.graph, "peter")) && p.get(1).equals(convertToVertex(this.graph, "lop"))
+ );
+ for (Predicate<Path> pathPredicate : pathsToAssert) {
+ Optional<Path> path = paths.stream().filter(pathPredicate).findAny();
+ assertTrue(path.isPresent());
+ assertTrue(paths.remove(path.get()));
+ }
+ assertTrue(paths.isEmpty());
+ }
+
+ public static class Traversals extends OptionalTest {
+
+ @Override
+ public Traversal<Vertex, Vertex> get_g_VX2X_optionalXoutXknowsXX(Object v2Id) {
+ return this.g.V(v2Id).optional(out("knows"));
+ }
+
+ @Override
+ public Traversal<Vertex, Vertex> get_g_VX2X_optionalXinXknowsXX(Object v2Id) {
+ return this.g.V(v2Id).optional(in("knows"));
+ }
+
+ @Override
+ public Traversal<Vertex, Path> get_g_V_hasLabelXpersonX_optionalXoutXknowsX_optionalXoutXcreatedXXX_path() {
+ return this.g.V().hasLabel("person").optional(out("knows").optional(out("created"))).path();
+ }
+
+ @Override
--- End diff --
Formatting is a big fuggly here. Why not just make it a one-liner?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203597001
Just a ``mvn clean install -pl gremlin-server -DskipIntegrationTests=false`` will be good enough I'd say as its only there that the assertions were commented out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-201925588
I'm not so sure that he has rights to do a publish-doc.she. I'm still a bit confused as to who else has access and under what circumstances they get access.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203345668
@okram Yes your GraphTraversalTest showed me the way.
mvn clean install SUCCESS
mvn clean install -DskipIntegrationTests=false
{code}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [ 4.726 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [ 1.531 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 26.490 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 7.425 s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [ 32.440 s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [ 3.856 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [02:08 min]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [03:46 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [04:28 min]
[INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [ 02:29 h]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [ 1.696 s]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 5.887 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [11:38 min]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [01:11 min]
[INFO] Apache TinkerPop :: Gremlin Archetype .............. SUCCESS [ 0.061 s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ........ SUCCESS [ 2.853 s]
[INFO] Apache TinkerPop :: Archetype - Server ............. SUCCESS [ 8.433 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:54 h
[INFO] Finished at: 2016-03-29T19:42:09+02:00
[INFO] Final Memory: 83M/394M
[INFO] ------------------------------------------------------------------------
{code}
**Note** 2 assertions were commented out to make the integration test suite pass.
``GremlinServerAuthIntegrateTest.shouldFailAuthenticateWithPlainTextNoCredentials``
``GremlinServerAuthOldIntegrateTest.shouldFailAuthenticateWithPlainTextNoCredentials``
The correct exception is thrown but the assertion tests for the message which is different on my system for some as yet unknown reason.
bin/process-docs.sh
Checked the optional gremlin output, looks good.
vote +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203429631
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203586286
Code looks and good and it worked as expected when I played with it in the shell. Nice addition.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203395102
We did discuss that. I have no idea why those won't work in his environment. I guess I will build this branch and see if there's any problems with Gremlin Server as a result of the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203599497
Just finished running `mvn verify -DskipIntegrationTests=false -pl gremlin-server` without issue.
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:17 min
[INFO] Finished at: 2016-03-30T14:33:01-05:00
[INFO] Final Memory: 33M/395M
[INFO] ------------------------------------------------------------------------
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#discussion_r57517425
--- Diff: docs/src/reference/the-traversal.asciidoc ---
@@ -1127,6 +1127,31 @@ g.V().repeat(both()).times(3).values('age').min()
IMPORTANT: `min(local)` determines the min of the current, local object (not the objects in the traversal stream).
This works for `Collection` and `Number`-type objects. For any other object, a min of `Double.NaN` is returned.
+[[optional-step]]
+Optional Step
+~~~~~~~~~~~~~
+
+The `optional()`-step returns the result of the specified traversal if it yields a result else it returns the calling
--- End diff --
please say that it is a `(*map*)-step` ... see the convention I use for other steps in the traversal.asciidoc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203419523
``mvn clean install -DincludeNeo4j``
{code}
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [ 2.872 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [ 1.384 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 23.977 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 6.627 s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [ 32.346 s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [ 3.490 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [01:09 min]
[INFO] Apache TinkerPop :: Gremlin Benchmark .............. SUCCESS [ 2.553 s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [02:36 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [03:24 min]
[INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [ 3.875 s]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [47:11 min]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 6.096 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [ 32.213 s]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [ 9.870 s]
[INFO] Apache TinkerPop :: Gremlin Archetype .............. SUCCESS [ 0.055 s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ........ SUCCESS [ 2.950 s]
[INFO] Apache TinkerPop :: Archetype - Server ............. SUCCESS [ 8.241 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 56:39 min
[INFO] Finished at: 2016-03-30T14:39:07+02:00
[INFO] Final Memory: 96M/441M
[INFO] ------------------------------------------------------------------------
{code}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-201909772
@pietermartin -- From just a code review, everything looks really clean and consistent with the conventions thus far. You added to `traversal.asciidoc`, you created a `GroovyOptionalTest` and an `OptionalTest`. Your test cases good. Finally, you were smart about adding `__.optional()`. Did my `GraphTraversalTest` open your eyes :) ?.
Please make sure the docs build. Better yet, `publish-docs.sh` after your `process-docs.sh` and then we can all see the new section online. Finally, please do a full integration test. If you can paste your `BUILD SUCCESSFUL` console output of your integration test run, that would be great. After that, I will vote.
Thank you Pieter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203600783
Great, tx
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Tinkerpop 968:Add first class su...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-203601055
hmm - so it seems that the issue is with your environment @pietermartin - weird. good to go for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---