You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xiedeyantu (via GitHub)" <gi...@apache.org> on 2024/03/16 15:05:11 UTC
[PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
xiedeyantu opened a new pull request, #32335:
URL: https://github.com/apache/doris/pull/32335
## Proposed changes
Issue Number: close #32323
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2008297857
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2003102953
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2007215890
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #32335:
URL: https://github.com/apache/doris/pull/32335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2007062014
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2003824981
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2002301803
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2003768410
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2002026409
<details>
<summary>TPC-H: <b>Total hot run time: 38000 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 71ffe10618e18155d32f7a7d4738dd192b8efb9c, data reload: false
------ Round 1 ----------------------------------
q1 17647 4195 4100 4100
q2 2019 149 138 138
q3 10608 1070 903 903
q4 7786 750 675 675
q5 7450 2621 2577 2577
q6 183 123 122 122
q7 1199 826 797 797
q8 9338 1949 1999 1949
q9 7213 6421 6410 6410
q10 8529 3494 3582 3494
q11 432 213 214 213
q12 791 285 299 285
q13 18102 2816 2858 2816
q14 283 252 246 246
q15 499 452 441 441
q16 503 381 386 381
q17 942 525 529 525
q18 7093 6483 6467 6467
q19 3278 1443 1367 1367
q20 539 290 268 268
q21 6019 3586 3522 3522
q22 345 304 329 304
Total cold run time: 110798 ms
Total hot run time: 38000 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4100 4075 4041 4041
q2 323 224 226 224
q3 2966 2802 2786 2786
q4 1794 1508 1507 1507
q5 5204 5224 5232 5224
q6 193 115 117 115
q7 2222 1816 1860 1816
q8 3133 3263 3265 3263
q9 8481 8497 8515 8497
q10 3719 3634 3657 3634
q11 538 431 431 431
q12 702 553 529 529
q13 16922 2888 2813 2813
q14 281 242 251 242
q15 484 454 433 433
q16 445 397 400 397
q17 1711 1481 1460 1460
q18 7403 7130 7071 7071
q19 1607 1546 1505 1505
q20 1910 1750 1682 1682
q21 4784 4652 4718 4652
q22 527 470 474 470
Total cold run time: 69449 ms
Total hot run time: 52792 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2008322018
run pipelinex_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2002013858
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2007199140
run pipelinex_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2009043930
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2003837303
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2002347106
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2007203847
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #32335:
URL: https://github.com/apache/doris/pull/32335#discussion_r1528337120
##########
regression-test/suites/partition_p0/multi_partition/test_multi_partition.groovy:
##########
@@ -465,4 +465,25 @@ suite("test_multi_partition") {
assertTrue(result2[1][1].startsWith("p_"))
sql "drop table multi_par12"
-}
\ No newline at end of file
+
+ // create one table without datetime partition, but with date string
+ sql """
Review Comment:
do u test nereids too? `set enable_fallback_to_original_planner=false` to disable fallback, and ensure it could work well on Nereids' `CreateTableComamnd`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #32335:
URL: https://github.com/apache/doris/pull/32335#discussion_r1528437307
##########
regression-test/suites/partition_p0/multi_partition/test_multi_partition.groovy:
##########
@@ -465,4 +465,25 @@ suite("test_multi_partition") {
assertTrue(result2[1][1].startsWith("p_"))
sql "drop table multi_par12"
-}
\ No newline at end of file
+
+ // create one table without datetime partition, but with date string
+ sql """
Review Comment:
```
mysql> set enable_fallback_to_original_planner=false;
Query OK, 0 rows affected (0.00 sec)
mysql> CREATE TABLE range_date_cast_to_datetime2 (id int, name string, pdate DATETIME) PARTITION BY RANGE(pdate)( FROM ("2023-04-16") TO ("2023-04-20") INTERVAL 1 DAY ) DISTRIBUTED BY HASH(id) BUCKETS 1 properties("replication_num" = "1");
Query OK, 0 rows affected (0.05 sec)
```
it can work well on nereids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2007216205
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2003342370
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2002312097
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] when partition column is datetime, date can work in create table command [doris]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #32335:
URL: https://github.com/apache/doris/pull/32335#issuecomment-2002016417
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org