You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2012/11/04 15:21:48 UTC

[v2] Refactor new code in

Hi All:

It seems to me like the new string map parsing configuration code in
LevelPatternConverter should be refactored with the existing code in
HighlightConverter and AnsiEscape. The low level code does the same thing:
parse a string map. The Highlight-Ansi code allows for white space around
the comma and equals, the new level code does not.

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [v2] Refactor new code in

Posted by Ralph Goers <rg...@apache.org>.

I noticed that when I wrote it, although the do it a bit differently. Yes, the new level code should also.  Look for how trim() is used.

Sent from my iPad

On Nov 4, 2012, at 6:21 AM, Gary Gregory <ga...@gmail.com> wrote:

> Hi All:
> 
> It seems to me like the new string map parsing configuration code in LevelPatternConverter should be refactored with the existing code in HighlightConverter and AnsiEscape. The low level code does the same thing: parse a string map. The Highlight-Ansi code allows for white space around the comma and equals, the new level code does not. 
> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory