You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/17 11:22:21 UTC

[GitHub] [apisix] nic-chen opened a new issue #3068: [DISCUSS] Do we need to keep `k8s_deployment_info` in Upstream?

nic-chen opened a new issue #3068:
URL: https://github.com/apache/apisix/issues/3068


   
   We originally hoped to save some k8s deployment information so that some third-party tools can maintain Upstream nodes based on this information. 
   
   But at present, few people use it, and it is easy to cause misunderstanding. So I wonder if this part should be removed now.
   
   What do you think?  Thanks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3068: [DISCUSS] Do we need to keep `k8s_deployment_info` in Upstream?

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3068:
URL: https://github.com/apache/apisix/issues/3068#issuecomment-747389244


   This field isn't used by APISIX now. Is there anywhere using it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on issue #3068: [DISCUSS] Do we need to keep `k8s_deployment_info` in Upstream?

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #3068:
URL: https://github.com/apache/apisix/issues/3068#issuecomment-747477097


   agree to remove this field


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3068: [DISCUSS] Do we need to keep `k8s_deployment_info` in Upstream?

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3068:
URL: https://github.com/apache/apisix/issues/3068#issuecomment-747388571


   Look like removing it will be a break change?
   https://github.com/apache/apisix/blob/f476d2c3dc68439406a9531fc8b4a2a2d50c1333/apisix/schema_def.lua#L386-L390


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis closed issue #3068: [DISCUSS] Do we need to keep `k8s_deployment_info` in Upstream?

Posted by GitBox <gi...@apache.org>.
membphis closed issue #3068:
URL: https://github.com/apache/apisix/issues/3068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nic-chen commented on issue #3068: [DISCUSS] Do we need to keep `k8s_deployment_info` in Upstream?

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #3068:
URL: https://github.com/apache/apisix/issues/3068#issuecomment-747419202


   > This field isn't used by APISIX now. Is there anywhere using it?
   
   none in open source projects


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org