You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/03/14 08:02:03 UTC

[GitHub] flink pull request #5694: [FLINK-8704][tests] Port SlotCountExceedingParalle...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5694

    [FLINK-8704][tests] Port SlotCountExceedingParallelismTest

    ## What is the purpose of the change
    
    This PR ports the `SlotCountExceedingParallelismTest` to flip6. The existing test was renamed to `LegacySlotCountExceedingParallelismTest`, and a ported copy was added.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8704_slot

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5694
    
----
commit bd6913fe5a430e9fa4b718c905ea16979eaab1d2
Author: zentol <ch...@...>
Date:   2018-03-12T12:52:57Z

    [FLINK-8704][tests] Port SlotCountExceedingParallelismTest

----


---

[GitHub] flink issue #5694: [FLINK-8704][tests] Port SlotCountExceedingParallelismTes...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5694
  
    that is true, yes. I'll update the PR, hang on.


---

[GitHub] flink issue #5694: [FLINK-8704][tests] Port SlotCountExceedingParallelismTes...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5694
  
    merging


---

[GitHub] flink issue #5694: [FLINK-8704][tests] Port SlotCountExceedingParallelismTes...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5694
  
    ah i remembered why.
    
    I had to copy the test because this test is in `flink-runtime`. Here we don't have access to the `MiniClusterResource`.


---

[GitHub] flink pull request #5694: [FLINK-8704][tests] Port SlotCountExceedingParalle...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5694


---

[GitHub] flink issue #5694: [FLINK-8704][tests] Port SlotCountExceedingParallelismTes...

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/5694
  
    @zentol, why did you have to copy `LegacySlotCountExceedingParallelismTest`? Shouldn't the new one work as well for non FLIP6?


---