You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/10 02:13:38 UTC
[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
adamfeuer opened a new pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393
## Summary
- SDMMC peripheral support for SAMA5D2 series microprocessors from Microchip
- provides an MMC/SD Card driver that works for reading and writing
- UHS_SDR50, UHS_DDR50, and UHS_SDR104 high-speed modes are supported, with
read/write speeds of 400Mbit/s in UHS_DDR50 (50MHz Double Data Rate) mode.
- This is a port of the NuttX imxrt_usdhc.c driver, as the SDMMC peripheral
uses a similar Cadence IP block.
- Basic instructions are in the README.txt.
## Impact
- None if you don't enable the SDMMC peripheral using the Kconfig system.
- Enables reading and writing to MMC or SD Cards. Only SD Cards have been
tested.
- VFAT filesystem has been tested and works. On the SAMA5D2-XULT board,
reading and writing to a bootable SD Card is supported.
## Testing
- Only tested on the SAMA5D2-XULT board from Microchip.
- Only manual read and write testing on a VFAT-formatted memory card
has been done.
- Driver was developed with extensive use of a logic analyzer to ensure
the SDMMC driver was functioning correctly.
- Only UHS_DDR50 mode was tested, as all my SD Cards support only that.
## How to Test
1. Format an SD Card with VFAT format.
1. Put some text files on the card.
1. Insert the card into the SAMA5D2-XULT SD Card slot.
1. Build the sama5d2-xult:sdmmcnsh configuration
1. Load NuttX onto the board
1. /mnt/mmcsd1 should have your files. You can cd, ls, cp, rm, and cat
to test the filesystem.
## TODO / Limitations
- e.MMC should work, but was not tested
- Performance tests have not been done
- UHS_SDR50 and UHS_SDR104 modes were not tested as I don't have any
SD Cards that support those modes.
## Notes
- nxstyle shows some formatting errors, but I couldn't find good ways
to make them go away without mangling the files. I welcome ideas on
how to better format the code so nxstyle passes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658918929
> For the rest of the nxstyle errors, what do you suggest? Should we just ignore them?
I don't see a way to make nxstyle happy without messing up the file, so that would be my suggestion.
One last thing, could you please squash the commits if you are happy with the changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-657802781
@btashton would you be willing to help me find someone who can review this?
I'm working to get [Groboard's GiantBoard](https://groboards.com/giant-board/) and the [ACME RoadRunner module](https://www.acmesystems.it/roadrunner) supported and added to NuttX— they're both SAMA5 boards so having SDMMC support would help. I know it's a lot of code, not sure how to avoid that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-659707723
@btashton Thanks for doing that. How does one restart the build? Is that something I can do without pushing a new change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658296884
@Ouss4 Ok, I changed the headers on the new files to Apache License 2.0, and removed the obsolete config value. Anything else to do here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-659717938
@Ouss4 You're welcome.
By the way, the "Re-run jobs" button doesn't show up for me. Maybe because I'm not a member of the NuttX Github team?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#discussion_r454685432
##########
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##########
@@ -0,0 +1,149 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_AUDIO_FORMAT_MP3 is not set
+# CONFIG_DISABLE_OS_API is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SAMA5_UART0 is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="sama5d2-xult"
+CONFIG_ARCH_BOARD_SAMA5D2_XULT=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_CHIP="sama5"
+CONFIG_ARCH_CHIP_ATSAMA5D27=y
+CONFIG_ARCH_CHIP_SAMA5=y
+CONFIG_ARCH_CHIP_SAMA5D2=y
+CONFIG_ARCH_INTERRUPTSTACK=2048
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ARCH_LOWVECTORS=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_AUDIO=y
+CONFIG_AUDIO_NUM_BUFFERS=8
+CONFIG_BOARDCTL_ROMDISK=y
+CONFIG_BOARD_LOOPSPERMSEC=65775
+CONFIG_BOOT_RUNFROMSDRAM=y
+CONFIG_BUILTIN=y
+CONFIG_CONSOLE_SYSLOG=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_ZERO=y
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_PARTITION=y
Review comment:
@Ouss4 will remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#discussion_r454675791
##########
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##########
@@ -0,0 +1,149 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_AUDIO_FORMAT_MP3 is not set
+# CONFIG_DISABLE_OS_API is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SAMA5_UART0 is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="sama5d2-xult"
+CONFIG_ARCH_BOARD_SAMA5D2_XULT=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_CHIP="sama5"
+CONFIG_ARCH_CHIP_ATSAMA5D27=y
+CONFIG_ARCH_CHIP_SAMA5=y
+CONFIG_ARCH_CHIP_SAMA5D2=y
+CONFIG_ARCH_INTERRUPTSTACK=2048
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ARCH_LOWVECTORS=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_AUDIO=y
+CONFIG_AUDIO_NUM_BUFFERS=8
+CONFIG_BOARDCTL_ROMDISK=y
+CONFIG_BOARD_LOOPSPERMSEC=65775
+CONFIG_BOOT_RUNFROMSDRAM=y
+CONFIG_BUILTIN=y
+CONFIG_CONSOLE_SYSLOG=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_ZERO=y
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_PARTITION=y
Review comment:
Doesn't exist anymore?
##########
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##########
@@ -0,0 +1,149 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_AUDIO_FORMAT_MP3 is not set
+# CONFIG_DISABLE_OS_API is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SAMA5_UART0 is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="sama5d2-xult"
+CONFIG_ARCH_BOARD_SAMA5D2_XULT=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_CHIP="sama5"
+CONFIG_ARCH_CHIP_ATSAMA5D27=y
+CONFIG_ARCH_CHIP_SAMA5=y
+CONFIG_ARCH_CHIP_SAMA5D2=y
+CONFIG_ARCH_INTERRUPTSTACK=2048
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ARCH_LOWVECTORS=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_AUDIO=y
+CONFIG_AUDIO_NUM_BUFFERS=8
+CONFIG_BOARDCTL_ROMDISK=y
+CONFIG_BOARD_LOOPSPERMSEC=65775
+CONFIG_BOOT_RUNFROMSDRAM=y
+CONFIG_BUILTIN=y
+CONFIG_CONSOLE_SYSLOG=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_ZERO=y
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_PARTITION=y
+CONFIG_EXAMPLES_TCPBLASTER=y
+CONFIG_EXAMPLES_TCPECHO=y
+CONFIG_EXAMPLES_WGET=y
+CONFIG_EXAMPLES_WGET_URL="http://10.0.0.1/"
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_AUTOMOUNTER=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_PROCFS_EXCLUDE_VERSION=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_HIDKBD_POLLUSEC=80000
+CONFIG_I2S=y
+CONFIG_INTELHEX_BINARY=y
+CONFIG_IOB_NBUFFERS=72
+CONFIG_IOB_THROTTLE=16
+CONFIG_MAX_TASKS=16
+CONFIG_MAX_WDOGPARMS=2
+CONFIG_NETDB_BUFSIZE=128
+CONFIG_NETINIT_NETLOCAL=y
+CONFIG_NETINIT_NOMAC=y
+CONFIG_NETUTILS_NETLIB_GENERICURLPARSER=y
Review comment:
Doesn't exist anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658462338
@Ouss4 Thanks, I pushed changes to remove the obsolete config values, I'll watch the CI and try to resolve any other problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-659682574
@adamfeuer Yes, sometimes some of the macOS checks don't make it to the end. It's Github things apparently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658924522
@Ouss4 Thank you. I will run one more set of manual tests on the SAMA5D2-XULT board, and also wait for the current set of CI builds to finish. If that all goes well, I'll squash and force-push, and then let you know I've done it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-659708166
@Ouss4 This is ready to merge now— the only thing that's not passing is the style check for some header files, as we discussed it's hard to get nxstyle to be happy with them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#discussion_r453953300
##########
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##########
@@ -0,0 +1,150 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_AUDIO_FORMAT_MP3 is not set
+# CONFIG_DISABLE_OS_API is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SAMA5_UART0 is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="sama5d2-xult"
+CONFIG_ARCH_BOARD_SAMA5D2_XULT=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_CHIP="sama5"
+CONFIG_ARCH_CHIP_ATSAMA5D27=y
+CONFIG_ARCH_CHIP_SAMA5=y
+CONFIG_ARCH_CHIP_SAMA5D2=y
+CONFIG_ARCH_INTERRUPTSTACK=2048
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ARCH_LOWVECTORS=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_AUDIO=y
+CONFIG_AUDIO_NUM_BUFFERS=8
+CONFIG_BOARDCTL_ROMDISK=y
+CONFIG_BOARD_LOOPSPERMSEC=65775
+CONFIG_BOOT_RUNFROMSDRAM=y
+CONFIG_BUILTIN=y
+CONFIG_CONSOLE_SYSLOG=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_ZERO=y
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_PARTITION=y
+CONFIG_EXAMPLES_TCPBLASTER=y
+CONFIG_EXAMPLES_TCPECHO=y
+CONFIG_EXAMPLES_WGET=y
+CONFIG_EXAMPLES_WGET_URL="http://10.0.0.1/"
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_AUTOMOUNTER=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_PROCFS_EXCLUDE_VERSION=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_HIDKBD_POLLUSEC=80000
+CONFIG_I2S=y
+CONFIG_INTELHEX_BINARY=y
+CONFIG_IOB_NBUFFERS=72
+CONFIG_IOB_THROTTLE=16
+CONFIG_MAX_TASKS=16
+CONFIG_MAX_WDOGPARMS=2
+CONFIG_NETDB_BUFSIZE=128
+CONFIG_NETINIT_NETLOCAL=y
+CONFIG_NETINIT_NOMAC=y
+CONFIG_NETUTILS_NETLIB_GENERICURLPARSER=y
+CONFIG_NETUTILS_TELNETC=y
+CONFIG_NETUTILS_WEBCLIENT=y
+CONFIG_NET_ARP_IPIN=y
+CONFIG_NET_ARP_SEND=y
+CONFIG_NET_BROADCAST=y
+CONFIG_NET_CDCECM=y
+CONFIG_NET_ETH_PKTSIZE=1514
+CONFIG_NET_ICMP=y
+CONFIG_NET_ICMP_SOCKET=y
+CONFIG_NET_ROUTE=y
+CONFIG_NET_STATISTICS=y
+CONFIG_NET_TCP=y
+CONFIG_NET_TCPBACKLOG=y
+CONFIG_NET_TCP_NOTIFIER=y
+CONFIG_NET_TCP_WRITE_BUFFERS=y
+CONFIG_NET_UDP=y
+CONFIG_NFILE_DESCRIPTORS=8
+CONFIG_NFILE_STREAMS=8
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_PROMPT_STRING="nsh> "
+CONFIG_NSH_QUOTE=y
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_MQ_MSGS=4
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_PREALLOC_WDOGS=16
+CONFIG_RAM_SIZE=268435456
+CONFIG_RAM_START=0x20000000
+CONFIG_RAM_VSTART=0x20000000
+CONFIG_RAW_BINARY=y
+CONFIG_READLINE_CMD_HISTORY=y
+CONFIG_READLINE_CMD_HISTORY_LEN=100
+CONFIG_READLINE_CMD_HISTORY_LINELEN=120
+CONFIG_READLINE_TABCOMPLETION=y
+CONFIG_RR_INTERVAL=200
+CONFIG_SAMA5D27_SDMMC0_MOUNT_BLKDEV="/dev/mmcsd0"
+CONFIG_SAMA5D27_SDMMC0_MOUNT_MOUNTPOINT="/mnt/mmcsd0"
+CONFIG_SAMA5D27_SDMMC1_MOUNT=y
+CONFIG_SAMA5D27_SDMMC1_MOUNT_BLKDEV="/dev/mmcsd1"
+CONFIG_SAMA5D27_SDMMC1_MOUNT_MOUNTPOINT="/mnt/mmcsd1"
+CONFIG_SAMA5D2XULT_528MHZ=y
+CONFIG_SAMA5D2XULT_USBHOST_STACKSIZE=2048
+CONFIG_SAMA5_BOOT_SDRAM=y
+CONFIG_SAMA5_DDRCS_HEAP_END=0x2fa00000
+CONFIG_SAMA5_DDRCS_RESERVE=y
+CONFIG_SAMA5_EHCI=y
+CONFIG_SAMA5_HSMC=y
+CONFIG_SAMA5_OHCI=y
+CONFIG_SAMA5_PIOA_IRQ=y
+CONFIG_SAMA5_PIOB_IRQ=y
+CONFIG_SAMA5_PIOC_IRQ=y
+CONFIG_SAMA5_PIO_IRQ=y
+CONFIG_SAMA5_RTC=y
+CONFIG_SAMA5_SDMMC0=y
+CONFIG_SAMA5_SDMMC0_SIZE=1073741824
+CONFIG_SAMA5_SDMMC=y
+CONFIG_SAMA5_TRNG=y
+CONFIG_SAMA5_UART1=y
+CONFIG_SAMA5_UDPHS=y
+CONFIG_SAMA5_UHPHS=y
+CONFIG_SCHED_HPWORKPRIORITY=192
+CONFIG_SCHED_LPNTHREADS=2
+CONFIG_SCHED_WAITPID=y
+CONFIG_SDCLONE_DISABLE=y
+CONFIG_SERIAL_TERMIOS=y
+CONFIG_SIG_DEFAULT=y
+CONFIG_SIG_EVTHREAD=y
+CONFIG_START_DAY=31
+CONFIG_START_MONTH=7
+CONFIG_START_YEAR=2014
+CONFIG_SYMTAB_ORDEREDBYNAME=y
+CONFIG_SYSLOG_TIMESTAMP=y
+CONFIG_SYSTEM_NSH=y
+CONFIG_SYSTEM_NSH_CXXINITIALIZE=y
Review comment:
This config doesn't exist anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#discussion_r454685483
##########
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##########
@@ -0,0 +1,149 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_AUDIO_FORMAT_MP3 is not set
+# CONFIG_DISABLE_OS_API is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SAMA5_UART0 is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="sama5d2-xult"
+CONFIG_ARCH_BOARD_SAMA5D2_XULT=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_CHIP="sama5"
+CONFIG_ARCH_CHIP_ATSAMA5D27=y
+CONFIG_ARCH_CHIP_SAMA5=y
+CONFIG_ARCH_CHIP_SAMA5D2=y
+CONFIG_ARCH_INTERRUPTSTACK=2048
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ARCH_LOWVECTORS=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_AUDIO=y
+CONFIG_AUDIO_NUM_BUFFERS=8
+CONFIG_BOARDCTL_ROMDISK=y
+CONFIG_BOARD_LOOPSPERMSEC=65775
+CONFIG_BOOT_RUNFROMSDRAM=y
+CONFIG_BUILTIN=y
+CONFIG_CONSOLE_SYSLOG=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_ZERO=y
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_PARTITION=y
+CONFIG_EXAMPLES_TCPBLASTER=y
+CONFIG_EXAMPLES_TCPECHO=y
+CONFIG_EXAMPLES_WGET=y
+CONFIG_EXAMPLES_WGET_URL="http://10.0.0.1/"
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_AUTOMOUNTER=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_PROCFS_EXCLUDE_VERSION=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_HIDKBD_POLLUSEC=80000
+CONFIG_I2S=y
+CONFIG_INTELHEX_BINARY=y
+CONFIG_IOB_NBUFFERS=72
+CONFIG_IOB_THROTTLE=16
+CONFIG_MAX_TASKS=16
+CONFIG_MAX_WDOGPARMS=2
+CONFIG_NETDB_BUFSIZE=128
+CONFIG_NETINIT_NETLOCAL=y
+CONFIG_NETINIT_NOMAC=y
+CONFIG_NETUTILS_NETLIB_GENERICURLPARSER=y
Review comment:
@Ouss4 Will remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-659712056
> How does one restart the build? Is that something I can do without pushing a new change?
In the checks tab, there is a button at the right that says "Re-run jobs".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658553303
@Ouss4 Ok, looks like all the non-nxstyle checks are passing. I ran nxstyle locally and fixed all the problems I could before submitting this PR; the remaining nxstyle issues I don't have good ideas about how to fix... if you have suggestions, please let me know!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658878834
@Ouss4 Oops, I am sorry I missed the easy ones. I'll fix the header name, the long lines, and the blank lines.
For the rest of the nxstyle errors, what do you suggest? Should we just ignore them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-659682574
@adamfeuer Yes, sometimes some of the macOS checks don't make it to the end. It's a Github thing apparently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-657917229
@Ouss4 Re: headers, will fix that. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658683071
>the remaining nxstyle issues I don't have good ideas about how to fix... if you have suggestions, please let me know!
For header file the "error: Invalid section for this file type" is a section named "Public Function" that needs to be "Public Function Prototypes". There are also a couple of long line and "too many blank lines" that can easily be fixed. For the rest, I don't see how to fix them, it's hard to make nxstyle happy with register definition files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-659602458
@Ouss4 I retested on hardware and force-pushed. Now it looks like the macOS (arm-12), (mips-riscv-x86-xtensa), and (sim) builds failed. But the Linux versions succeeded. Is this expected?
If these failures are unexpected— will you let me know how to debug? I don't see any detail from the CI runs.
If these failures are ok, then this PR is ready to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-659686554
> @adamfeuer Yes, sometimes some of the macOS checks don't make it to the end. It's Github things apparently.
I actually re-kicked the build a while back and they are passing now. For some reason the old canceled jobs are showing up on this run. But you will also see the new Mac jobs that passed.
All that is failing is the style check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658300580
@Ouss4 BTW the two main files, [sam_sdmmc.h](https://github.com/starcat-io/incubator-nuttx/blob/feature/sama5d27-sdmmc-support/arch/arm/src/sama5/hardware/sam_sdmmc.h) and [sam_sdmmc.c](https://github.com/starcat-io/incubator-nuttx/blob/feature/sama5d27-sdmmc-support/arch/arm/src/sama5/sam_sdmmc.c) are ported from [imxrt_usdhc.h](https://github.com/starcat-io/incubator-nuttx/blob/feature/sama5d27-sdmmc-support/arch/arm/src/imxrt/hardware/imxrt_usdhc.h) and [imxrt_usdhc.c](https://github.com/starcat-io/incubator-nuttx/blob/feature/sama5d27-sdmmc-support/arch/arm/src/imxrt/imxrt_usdhc.c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #1393: SAMA5D2x SDMMC peripheral support (SD Card driver)
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#discussion_r454047957
##########
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##########
@@ -0,0 +1,150 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_AUDIO_FORMAT_MP3 is not set
+# CONFIG_DISABLE_OS_API is not set
+# CONFIG_NSH_ARGCAT is not set
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_NSH_CMDPARMS is not set
+# CONFIG_SAMA5_UART0 is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="sama5d2-xult"
+CONFIG_ARCH_BOARD_SAMA5D2_XULT=y
+CONFIG_ARCH_BUTTONS=y
+CONFIG_ARCH_CHIP="sama5"
+CONFIG_ARCH_CHIP_ATSAMA5D27=y
+CONFIG_ARCH_CHIP_SAMA5=y
+CONFIG_ARCH_CHIP_SAMA5D2=y
+CONFIG_ARCH_INTERRUPTSTACK=2048
+CONFIG_ARCH_IRQBUTTONS=y
+CONFIG_ARCH_LOWVECTORS=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_AUDIO=y
+CONFIG_AUDIO_NUM_BUFFERS=8
+CONFIG_BOARDCTL_ROMDISK=y
+CONFIG_BOARD_LOOPSPERMSEC=65775
+CONFIG_BOOT_RUNFROMSDRAM=y
+CONFIG_BUILTIN=y
+CONFIG_CONSOLE_SYSLOG=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_ZERO=y
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_PARTITION=y
+CONFIG_EXAMPLES_TCPBLASTER=y
+CONFIG_EXAMPLES_TCPECHO=y
+CONFIG_EXAMPLES_WGET=y
+CONFIG_EXAMPLES_WGET_URL="http://10.0.0.1/"
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FS_AUTOMOUNTER=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_PROCFS_EXCLUDE_VERSION=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_HIDKBD_POLLUSEC=80000
+CONFIG_I2S=y
+CONFIG_INTELHEX_BINARY=y
+CONFIG_IOB_NBUFFERS=72
+CONFIG_IOB_THROTTLE=16
+CONFIG_MAX_TASKS=16
+CONFIG_MAX_WDOGPARMS=2
+CONFIG_NETDB_BUFSIZE=128
+CONFIG_NETINIT_NETLOCAL=y
+CONFIG_NETINIT_NOMAC=y
+CONFIG_NETUTILS_NETLIB_GENERICURLPARSER=y
+CONFIG_NETUTILS_TELNETC=y
+CONFIG_NETUTILS_WEBCLIENT=y
+CONFIG_NET_ARP_IPIN=y
+CONFIG_NET_ARP_SEND=y
+CONFIG_NET_BROADCAST=y
+CONFIG_NET_CDCECM=y
+CONFIG_NET_ETH_PKTSIZE=1514
+CONFIG_NET_ICMP=y
+CONFIG_NET_ICMP_SOCKET=y
+CONFIG_NET_ROUTE=y
+CONFIG_NET_STATISTICS=y
+CONFIG_NET_TCP=y
+CONFIG_NET_TCPBACKLOG=y
+CONFIG_NET_TCP_NOTIFIER=y
+CONFIG_NET_TCP_WRITE_BUFFERS=y
+CONFIG_NET_UDP=y
+CONFIG_NFILE_DESCRIPTORS=8
+CONFIG_NFILE_STREAMS=8
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=512
+CONFIG_NSH_PROMPT_STRING="nsh> "
+CONFIG_NSH_QUOTE=y
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_MQ_MSGS=4
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_PREALLOC_WDOGS=16
+CONFIG_RAM_SIZE=268435456
+CONFIG_RAM_START=0x20000000
+CONFIG_RAM_VSTART=0x20000000
+CONFIG_RAW_BINARY=y
+CONFIG_READLINE_CMD_HISTORY=y
+CONFIG_READLINE_CMD_HISTORY_LEN=100
+CONFIG_READLINE_CMD_HISTORY_LINELEN=120
+CONFIG_READLINE_TABCOMPLETION=y
+CONFIG_RR_INTERVAL=200
+CONFIG_SAMA5D27_SDMMC0_MOUNT_BLKDEV="/dev/mmcsd0"
+CONFIG_SAMA5D27_SDMMC0_MOUNT_MOUNTPOINT="/mnt/mmcsd0"
+CONFIG_SAMA5D27_SDMMC1_MOUNT=y
+CONFIG_SAMA5D27_SDMMC1_MOUNT_BLKDEV="/dev/mmcsd1"
+CONFIG_SAMA5D27_SDMMC1_MOUNT_MOUNTPOINT="/mnt/mmcsd1"
+CONFIG_SAMA5D2XULT_528MHZ=y
+CONFIG_SAMA5D2XULT_USBHOST_STACKSIZE=2048
+CONFIG_SAMA5_BOOT_SDRAM=y
+CONFIG_SAMA5_DDRCS_HEAP_END=0x2fa00000
+CONFIG_SAMA5_DDRCS_RESERVE=y
+CONFIG_SAMA5_EHCI=y
+CONFIG_SAMA5_HSMC=y
+CONFIG_SAMA5_OHCI=y
+CONFIG_SAMA5_PIOA_IRQ=y
+CONFIG_SAMA5_PIOB_IRQ=y
+CONFIG_SAMA5_PIOC_IRQ=y
+CONFIG_SAMA5_PIO_IRQ=y
+CONFIG_SAMA5_RTC=y
+CONFIG_SAMA5_SDMMC0=y
+CONFIG_SAMA5_SDMMC0_SIZE=1073741824
+CONFIG_SAMA5_SDMMC=y
+CONFIG_SAMA5_TRNG=y
+CONFIG_SAMA5_UART1=y
+CONFIG_SAMA5_UDPHS=y
+CONFIG_SAMA5_UHPHS=y
+CONFIG_SCHED_HPWORKPRIORITY=192
+CONFIG_SCHED_LPNTHREADS=2
+CONFIG_SCHED_WAITPID=y
+CONFIG_SDCLONE_DISABLE=y
+CONFIG_SERIAL_TERMIOS=y
+CONFIG_SIG_DEFAULT=y
+CONFIG_SIG_EVTHREAD=y
+CONFIG_START_DAY=31
+CONFIG_START_MONTH=7
+CONFIG_START_YEAR=2014
+CONFIG_SYMTAB_ORDEREDBYNAME=y
+CONFIG_SYSLOG_TIMESTAMP=y
+CONFIG_SYSTEM_NSH=y
+CONFIG_SYSTEM_NSH_CXXINITIALIZE=y
Review comment:
@Ouss4 Ok, will remove. I'll run it through make menuconfig again after merging in master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org