You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/03 09:36:24 UTC
[GitHub] [skywalking] seifeHu opened a new pull request #4169: Update
log4j2.xml
seifeHu opened a new pull request #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169
- [ ] Improve performance
Too many larger log files can causes the hard disk to become full ,add .gz and TimeBasedTriggeringPolicy . add the two changes ,the skywalking oap logs will be zipped in .gz file .
This changes can make the oap server run longer times .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4169: FAQ for backend
log4j2.xml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4169: FAQ for backend log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-573965687
@kezhenxu94 @JaredTan95 Should we close this? As no update in 10 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] seifeHu commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
seifeHu commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570552435
> My question is for gz. This is only a requirement for all users, from my understanding. If you have the use case, please consider to add a FAQ doc, rather than changing this.
In my case , about running 15 days . My oap logs got more than 60G . so I think default log config do zip . Can lead to oap server to running longer times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4169: Update
log4j2.xml
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570536635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=h1) Report
> Merging [#4169](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/99100ed635522fb5142230e7a7c03d8011c2f8a1?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4169 +/- ##
==========================================
+ Coverage 26.78% 26.83% +0.04%
==========================================
Files 1161 1161
Lines 25410 25410
Branches 3689 3689
==========================================
+ Hits 6807 6819 +12
+ Misses 17997 17982 -15
- Partials 606 609 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4169/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=footer). Last update [99100ed...7e6e95d](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 closed pull request #4169: FAQ for backend
log4j2.xml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed pull request #4169: FAQ for backend log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] JaredTan95 commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-571592572
We also used `.gz` feature to compress log file size in our scenario, but It doesn't mean suitable for all users. So, Let's keep it and add FAQ docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4169: FAQ for backend
log4j2.xml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4169: FAQ for backend log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-573994301
Prefer to close it and reopen or open another PR if @seifehu is ready
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570773296
I'm totally agree to keep it unchanged because the changes here are just configurations from third-party framework (log4j), users should modify the configurations in their own environments instead of in SkyWalking repo, we cannot meet every user's requirement if future users don't like the archived logs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570769428
@kezhenxu94 @arugal @JaredTan95 Any suggestion about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] seifeHu commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
seifeHu commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570790276
ok. I will make this content into FAQ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-571401200
@seifeHu any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570520832
My question is for gz. This is only a requirement for all users, from my understanding. If you have the use case, please consider to add a FAQ doc, rather than changing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570554099
I mean, users could have different solution. Such as using error log only, close log for some packages, or like you using zip mode. My point, yours is just one option. It fits FAQ more than changing the distance tar permanently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4169: Update log4j2.xml
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4169: Update log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570536635
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=h1) Report
> Merging [#4169](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0f6b5c8def0f462c584b2eb336166028c09d459d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4169 +/- ##
=======================================
Coverage 26.83% 26.83%
=======================================
Files 1161 1161
Lines 25409 25409
Branches 3689 3689
=======================================
Hits 6819 6819
Misses 17981 17981
Partials 609 609
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=footer). Last update [0f6b5c8...baa058f](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4169: FAQ for backend
log4j2.xml
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4169: FAQ for backend log4j2.xml
URL: https://github.com/apache/skywalking/pull/4169#issuecomment-573477373
@seifeHu Could you update this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services