You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/24 11:37:36 UTC

[GitHub] [spark] iRakson opened a new pull request #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

iRakson opened a new pull request #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683
 
 
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   Added new parameter `checkOverflow` to remove dependency on `SQLConf.get`.
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   This allows to avoid the issue when the configuration change between different phases of planning, and this can silently break a query plan which can lead to crashes or data corruption.
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce any user-facing change?
   No
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   Existing UTs.
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] iRakson commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
iRakson commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590280395
 
 
   cc @cloud-fan @HyukjinKwon 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590282106
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590282457
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590282106
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590650649
 
 
   I don't think we have reached any conclusion about other instances, and we haven't made any guarantee about the effective time of configurations. I am -1 to fix other instances without having clear definitions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590316868
 
 
   OK to test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590317541
 
 
   Actually, the behavior is already fixed after the expression is created, as the flag is declared as `private val checkOverflow = SQLConf.get.ansiEnabled`.
   
   So this PR just makes it more stable, to avoid some corner cases like transform the expression tree with a different SQL config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590297883
 
 
   This doesn't change data type/nullability, so we need to discuss whether or not we should fix the behavior after the expression is created. cc @viirya @maropu 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yaooqinn commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590329590
 
 
   
   > So this PR just makes it more stable, to avoid some corner cases like transform the expression tree with a different SQL config.
   
   
   Does it need to keep the config here? https://github.com/apache/spark/pull/27683/files#diff-383a8cdd0a9c58cae68e0a79295520a3R435

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27683: [SPARK-30917][SQL]: The behaviour of UnaryMinus should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27683#issuecomment-590282457
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org