[GitHub] [incubator-mxnet] zleyk22 commented on issue #18078: [Numpy] Gradient of np.prod is wrong when there are zeros in the array

[GitBox <gi...@apache.org>]

zleyk22 commented on issue #18078:
URL: https://github.com/apache/incubator-mxnet/issues/18078#issuecomment-628246366


   Yes, and no. I have been looking into this code, but there are many 
   parts of the code which are not clear for me. Therefore, I am not sure 
   how to fix it in a reasonable way in order not to introduce more bugs. I 
   was investigating how this code was written. What I saw, this code was 
   written by Eric Junyuan Xie in the end of 2016. I thought that going 
   back in time I would learn how this code was written and would find some 
   comments and explanations. But there was nothing which suggested why the 
   author chose that way of implementing. So currently, I am not going to 
   fix it. I prefer to wait a while in order to figure out what to do next. 
   Maybe it would be advisable to talk to Eric Junyuan Xie to learn more 
   about his code?
   
   On 5/13/20 3:45 PM, Yizhi Liu wrote:
   >
   > @zleyk22 <https://github.com/zleyk22> are you working on this?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub 
   > <https://github.com/apache/incubator-mxnet/issues/18078#issuecomment-628236372>, 
   > or unsubscribe 
   > <https://github.com/notifications/unsubscribe-auth/AO3PCD67QIMEOXF2TMBRE3LRRMBG5ANCNFSM4MJCT54Q>.
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org