You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "matrei (via GitHub)" <gi...@apache.org> on 2025/07/21 21:34:06 UTC
[PR] Revert to Sitemesh 2 [grails-spring-security]
matrei opened a new pull request, #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144
Grails 7.0.0-M5 has reverted to Sitemesh 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2225715196
##########
buildSrc/build.gradle:
##########
@@ -57,7 +57,9 @@ dependencies {
implementation "org.nosphere.apache.rat:org.nosphere.apache.rat.gradle.plugin:${versions.get('ratVersion')}"
implementation "org.gradle.crypto.checksum:org.gradle.crypto.checksum.gradle.plugin:${versions.get('gradleCryptoChecksumVersion')}"
- testImplementation 'org.spockframework:spock-core'
+ testImplementation 'org.spockframework:spock-core', {
+ exclude(group: 'org.codehaus.groovy') // Use Gradle provided version because: Could not resolve org.codehaus.groovy:groovy:3.0.12
Review Comment:
Yes, buildSrc has a Spock test.
Groovy 3 should be what is running that test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3108653410
The LDAP configuration that I was speaking about are the changes to:
plugin-ldap/examples/retrieve-db-roles/grails-app/conf/application.groovy
plugin-ldap/examples/retrieve-db-roles/grails-app/init/com/test/Application.groovy
Right now we're putting load on an external service (ldap.forumsys.com:389) and I've seen it block us. Our tests should use local ldap instead of relying on an external website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2221397857
##########
plugin-ui/examples/simple/build.gradle:
##########
@@ -32,7 +32,7 @@ dependencies {
implementation project(':ui-plugin')
implementation 'org.apache.grails:grails-core'
implementation 'org.apache.grails:grails-gsp'
- implementation "org.apache.grails.views:grails-layout:$grailsVersion"
+ implementation 'org.apache.grails.views:grails-layout'
Review Comment:
See: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2221385719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3104428565
I think we also need to change the ldap configuration for these projects like I did here: https://github.com/apache/grails-spring-security/pull/1143/files
We're pointing to an external website to use ldap, instead of using one local for our test run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3108239029
> The dependencies in the example projects still need cleaned up - so they only include coordinates that we expect users to include (org.apache.grails). Otherwise, we'll have to reroll this again in the next release.
I don't understand why this is the case with functional test applications.
> Can we add the debug in test-config.gradle that I added in the other PR so that we can comment in the future to help troubleshoot?
Are you referring to the Geb reporting?
I see in #1143 that there are two different reporting directory system properties configured:
- `geb.build.reportsDir`
- `grails.geb.reporting.directory`
Is the former still used?
> Can we turn off the spring dependency management plugin for the non-examples / plugins?
I think this is already done in `plugin-config.gradle`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3108797663
> The LDAP configuration that I was speaking about are the changes to:
>
> plugin-ldap/examples/retrieve-db-roles/grails-app/conf/application.groovy plugin-ldap/examples/retrieve-db-roles/grails-app/init/com/test/Application.groovy
>
> Right now we're putting load on an external service (ldap.forumsys.com:389) and I've seen it block us. Our tests should use local ldap instead of relying on an external website.
I have updated the `retrieve-db-roles` test application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3109049515
My only remaining concern here is the out of date dependencies on the functional test apps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2220570191
##########
plugin-ui/plugin/build.gradle:
##########
@@ -45,7 +45,7 @@ dependencies {
implementation 'org.apache.grails:grails-controllers'
implementation 'org.apache.grails:grails-converters'
implementation 'org.apache.grails:grails-gsp'
- implementation "org.apache.grails.views:grails-layout:$grailsVersion"
+ implementation 'org.apache.grails.views:grails-layout'
Review Comment:
We shouldn't be including internal libraries - in the M5 it's supposed to be included via the include of GSP.Including this here will cause it to break again on the RC1
##########
plugin-ui/examples/extended/grails-app/views/layouts/register.gsp:
##########
@@ -19,7 +19,6 @@
<!doctype html>
<html class="no-js" lang="">
<head>
- <title><g:layoutTitle/></title>
Review Comment:
Was there a race condition with the layout title? the html seemed to be the same when i dumped it.
##########
plugin-ui/examples/simple/build.gradle:
##########
@@ -32,7 +32,7 @@ dependencies {
implementation project(':ui-plugin')
implementation 'org.apache.grails:grails-core'
implementation 'org.apache.grails:grails-gsp'
- implementation "org.apache.grails.views:grails-layout:$grailsVersion"
+ implementation 'org.apache.grails.views:grails-layout'
Review Comment:
We shouldn't be including internal libraries - in the M5 it's supposed to be included via the include of GSP. Including this here will cause it to break again on the RC1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3101305221
> I'm assuming the real fix here was the remove of the waitFors - and leaving the selenium workaround in place?
No, I think it was removing the `<g:layoutTitle/>` that fixed it. I don't know how you could see the title in the Geb report. Running bootRun and visiting the pages in question did not output any titles for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3102561195
> > I'm assuming the real fix here was the remove of the waitFors - and leaving the selenium workaround in place?
>
> No, I think it was removing the `<g:layoutTitle/>` that fixed it. I don't know how you could see the title in the Geb report. Running bootRun and visiting the pages in question did not output any titles for me.
If you add `group('some name')` and turn on reporting in the annotation, it will dump the html rendered to the browser. That's how I often debug geb failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2222412829
##########
plugin-ui/examples/extended/grails-app/views/layouts/register.gsp:
##########
@@ -19,7 +19,6 @@
<!doctype html>
<html class="no-js" lang="">
<head>
- <title><g:layoutTitle/></title>
Review Comment:
Ok, that makes a lot more sense. It's good to revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2221385719
##########
plugin-ui/plugin/build.gradle:
##########
@@ -45,7 +45,7 @@ dependencies {
implementation 'org.apache.grails:grails-controllers'
implementation 'org.apache.grails:grails-converters'
implementation 'org.apache.grails:grails-gsp'
- implementation "org.apache.grails.views:grails-layout:$grailsVersion"
+ implementation 'org.apache.grails.views:grails-layout'
Review Comment:
OK, it seems this has changed again after M5: apache/grails-core@cdbb4df7b2c635c69d4d3c403197ec6c390f8b19?
So either way, `grails-layout` this needs to be added back (in the `org.apache.grails` group) for the next release, right?
##########
plugin-ui/examples/extended/grails-app/views/layouts/register.gsp:
##########
@@ -19,7 +19,6 @@
<!doctype html>
<html class="no-js" lang="">
<head>
- <title><g:layoutTitle/></title>
Review Comment:
I'm not sure. I only know this was added so that titles worked with Sitemesh 3: cf474349091ec32d49fa50dc230972e7d10631c9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2223571471
##########
buildSrc/build.gradle:
##########
@@ -57,7 +57,9 @@ dependencies {
implementation "org.nosphere.apache.rat:org.nosphere.apache.rat.gradle.plugin:${versions.get('ratVersion')}"
implementation "org.gradle.crypto.checksum:org.gradle.crypto.checksum.gradle.plugin:${versions.get('gradleCryptoChecksumVersion')}"
- testImplementation 'org.spockframework:spock-core'
+ testImplementation 'org.spockframework:spock-core', {
+ exclude(group: 'org.codehaus.groovy') // Use Gradle provided version because: Could not resolve org.codehaus.groovy:groovy:3.0.12
Review Comment:
Why do we include test frameworks in build src? This would be groovy 3 which is what the gradle-bom includes. Is this a mistake? If the buildSrc has tests then we would want to use groovy 3 since groovy 3 is what gradle will use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2223559359
##########
plugin-ui/plugin/build.gradle:
##########
@@ -45,7 +45,7 @@ dependencies {
implementation 'org.apache.grails:grails-controllers'
implementation 'org.apache.grails:grails-converters'
implementation 'org.apache.grails:grails-gsp'
- implementation "org.apache.grails.views:grails-layout:$grailsVersion"
+ implementation 'org.apache.grails.views:grails-layout'
Review Comment:
You are correct, for the next release we should have to add it, but I would assume we would add it by include `grails-dependencies-all` instead. If you want to wait to do this change, I'm ok waiting until the next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#discussion_r2221385719
##########
plugin-ui/plugin/build.gradle:
##########
@@ -45,7 +45,7 @@ dependencies {
implementation 'org.apache.grails:grails-controllers'
implementation 'org.apache.grails:grails-converters'
implementation 'org.apache.grails:grails-gsp'
- implementation "org.apache.grails.views:grails-layout:$grailsVersion"
+ implementation 'org.apache.grails.views:grails-layout'
Review Comment:
OK, it seems this has changed again after M5: apache/grails-core@cdbb4df7b2c635c69d4d3c403197ec6c390f8b19?
So either way, `grails-layout` needs to be added back (in the `org.apache.grails` group) for the next release, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3108619587
On the geb configuration, I was talking about this code:
systemProperty 'grails.geb.reporting.directory', reporting.file("$project.projectDir/build/geb-reports").canonicalFile.absolutePath
// systemProperty 'grails.geb.recording.mode', 'RECORD_ALL'
For the functional tests, we should be testing with the same dependencies that end applications will use. From what I can tell, there has been divergence from a generated application and the applications in this project.
For the plugin-config.gradle, that's only applied to the plugins. I think we should turn the Spring Dependency Management gradle plugin off in the functional test apps because it can cause us to unknowingly pull from a repo instead of use the local projects. This happened multiple times in the grails-core merge, and the only reason we caught it was because we were changing coordinates. Using gradle platforms guarantees we pull dependencies from the local project and never from a configure repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3102818220
> > > I'm assuming the real fix here was the remove of the waitFors - and leaving the selenium workaround in place?
> >
> >
> > No, I think it was removing the `<g:layoutTitle/>` that fixed it. I don't know how you could see the title in the Geb report. Running bootRun and visiting the pages in question did not output any titles for me.
>
> If you add `group('some name')` and turn on reporting in the annotation, it will dump the html rendered to the browser. That's how I often debug geb failures.
OK, sorry for being unclear. I meant, I don't know how the titles could be output when you ran the tests (with reporting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3099938876
I'm assuming the real fix here was the remove of the waitFors - and leaving the selenium workaround in place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert to Sitemesh 2 [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #1144:
URL: https://github.com/apache/grails-spring-security/pull/1144#issuecomment-3109624919
> My only remaining concern here is the out of date dependencies on the functional test apps
The thing is, we can't just update the versions. The CSS class names and HTML structure has changed in later versions of Bootstrap. If we set out to keep the UI of old functional test applications up-to-date, we will have a lot of work.
I'm not saying it shouldn't ever be done, but I think it is out of scope for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org