[GitHub] [spark] karenfeng commented on pull request #33995: [SPARK-36754][SQL] ArrayIntersect handle duplicated Double.NaN and Float.NaN

[GitBox <gi...@apache.org>]

karenfeng commented on pull request #33995:
URL: https://github.com/apache/spark/pull/33995#issuecomment-928263469


   For clarification @AngersZhuuuu: the PR description says:
   
   > For query
   > ```
   > select array_intersect(array(cast('nan' as double), 1d), array(cast('nan' as double)))
   > ```
   > This returns [NaN], but it should return [].
   
   Is this the right way around? It seems like we now correctly return `[NaN]`, but previously incorrectly returned `[]`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org