You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/04/07 13:45:20 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4009: [ARTEMIS-3756]: Enabling extra parameters to be passed by the URI.

clebertsuconic commented on code in PR #4009:
URL: https://github.com/apache/activemq-artemis/pull/4009#discussion_r845154841


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java:
##########
@@ -425,10 +425,10 @@
            format = Message.Format.MESSAGE_FORMAT)
    void broadcastTimeout(int retry, int maxretry);
 
-   @LogMessage(level = Logger.Level.WARN)
-   @Message(id = 212078, value = "Connection factory parameter ignored {0}",
-      format = Message.Format.MESSAGE_FORMAT)
-   void connectionFactoryParameterIgnored(String parameterName);

Review Comment:
   Can you just remove this, and call logger.debug directly where this is being called.
   
   We always use logger.debug at the logger on the class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org