[jira] [Updated] (TAP5-2068) Use , not , tags for the close buttons on alerts

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-2068:
---------------------------------------

    Summary: Use <button>, not <a>, tags for the close buttons on alerts  (was: Add type="button" to buttons used to close alerts)
    
> Use <button>, not <a>, tags for the close buttons on alerts
> -----------------------------------------------------------
>
>                 Key: TAP5-2068
>                 URL: https://issues.apache.org/jira/browse/TAP5-2068
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Dustin Woods
>            Priority: Minor
>         Attachments: 0002-Add-type-button-to-buttons-used-to-close-alerts.patch
>
>
> Add type="button" to button used to close alerts so the enter key continues to submit the form if the alerts block is inside a form.
> I don't know much about coffeescript but the javascript changes below makes it work for me.
> From:
>     element = builder("div", {
>       "class": className
>     }, ["button.close", "\u00d7"], content);
> To:
>     element = builder("div", {
>       "class": className
>     }, ["button.close", {
>       "type":"button"
>     }, "\u00d7"], content);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira