[GitHub] spark pull request: [MLLIB] SPARK-4231, SPARK-3066: Add RankingMet...

[mengxr <gi...@git.apache.org>]

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3098#discussion_r24955624
  
    --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/MovieLensALS.scala ---
    @@ -18,14 +18,14 @@
     package org.apache.spark.examples.mllib
     
     import scala.collection.mutable
    -
     import org.apache.log4j.{Level, Logger}
     import scopt.OptionParser
    -
     import org.apache.spark.{SparkConf, SparkContext}
     import org.apache.spark.SparkContext._
     import org.apache.spark.mllib.recommendation.{ALS, MatrixFactorizationModel, Rating}
     import org.apache.spark.rdd.RDD
    +import org.apache.spark.mllib.evaluation.RankingMetrics
    +import org.jblas.DoubleMatrix
    --- End diff --
    
    organize imports (https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-Imports).
    
    Do not use JBLAS because we plan to remove it in 1.4. Use breeze/netlib-java instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org