You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/26 01:38:45 UTC

[GitHub] [hudi] danny0405 commented on a change in pull request #4117: [HUDI-2852] Table metadata returns empty for non-exist partition

danny0405 commented on a change in pull request #4117:
URL: https://github.com/apache/hudi/pull/4117#discussion_r757181320



##########
File path: hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
##########
@@ -131,6 +132,10 @@ private void initIfNeeded() {
       HoodieFileReader baseFileReader = readers.getKey();
       HoodieMetadataMergedLogRecordReader logRecordScanner = readers.getRight();
 
+      if (baseFileReader == null && logRecordScanner == null) {
+        return Collections.emptyList();

Review comment:
       I think we should not, the original code returns key based on the metadata data file content, but here we do not have any data file actually.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org