You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/11 01:36:17 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #18867: Revert "[PIP-167][Authorization] Make it Configurable to Require Subscription Permission"
tisonkun opened a new pull request, #18867:
URL: https://github.com/apache/pulsar/pull/18867
Reverts apache/pulsar#15576
After an offline discussion with @michaeljmarshall I learned that there can be a better solution than this PR implements. Also, the original PIP associated to this PR didn't have a formal resolution.
Pending to revert first.
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #18867: Revert "[PIP-167][Authorization] Make it Configurable to Require Subscription Permission"
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #18867:
URL: https://github.com/apache/pulsar/pull/18867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18867: Revert "[PIP-167][Authorization] Make it Configurable to Require Subscription Permission"
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18867:
URL: https://github.com/apache/pulsar/pull/18867#issuecomment-1345465613
> "semantic pull request" check to allow this kind of PR to get merged.
I think we have discussed it in the original mails. We have a `[revert]` type, I can follow it the next time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18867: Revert "[PIP-167][Authorization] Make it Configurable to Require Subscription Permission"
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18867:
URL: https://github.com/apache/pulsar/pull/18867#issuecomment-1345432634
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18867](https://codecov.io/gh/apache/pulsar/pull/18867?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0abf263) into [master](https://codecov.io/gh/apache/pulsar/commit/1b5722d35a2cbce35d1d0843fa6a999da5feb583?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b5722d) will **decrease** coverage by `9.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18867 +/- ##
============================================
- Coverage 46.34% 37.07% -9.28%
+ Complexity 10394 1967 -8427
============================================
Files 703 209 -494
Lines 68838 14425 -54413
Branches 7379 1574 -5805
============================================
- Hits 31905 5348 -26557
+ Misses 33324 8491 -24833
+ Partials 3609 586 -3023
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `37.07% <ø> (-9.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ookkeeper/mledger/impl/ManagedCursorContainer.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRDdXJzb3JDb250YWluZXIuamF2YQ==) | | |
| [...r/service/AbstractDispatcherMultipleConsumers.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Fic3RyYWN0RGlzcGF0Y2hlck11bHRpcGxlQ29uc3VtZXJzLmphdmE=) | | |
| [...ava/org/apache/pulsar/broker/service/Consumer.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0NvbnN1bWVyLmphdmE=) | | |
| [...a/org/apache/bookkeeper/mledger/ManagedCursor.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9NYW5hZ2VkQ3Vyc29yLmphdmE=) | | |
| [...he/pulsar/broker/service/AnalyzeBacklogResult.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0FuYWx5emVCYWNrbG9nUmVzdWx0LmphdmE=) | | |
| [...ion/pendingack/impl/MLPendingAckReplyCallBack.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9wZW5kaW5nYWNrL2ltcGwvTUxQZW5kaW5nQWNrUmVwbHlDYWxsQmFjay5qYXZh) | | |
| [...ar/broker/loadbalance/impl/BundleSplitterTask.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL0J1bmRsZVNwbGl0dGVyVGFzay5qYXZh) | | |
| [...sar/broker/resourcegroup/ResourceGroupService.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9yZXNvdXJjZWdyb3VwL1Jlc291cmNlR3JvdXBTZXJ2aWNlLmphdmE=) | | |
| [...ava/org/apache/pulsar/broker/admin/v3/Sources.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92My9Tb3VyY2VzLmphdmE=) | | |
| [...ulsar/utils/ConcurrentBitmapSortedLongPairSet.java](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL3V0aWxzL0NvbmN1cnJlbnRCaXRtYXBTb3J0ZWRMb25nUGFpclNldC5qYXZh) | | |
| ... and [485 more](https://codecov.io/gh/apache/pulsar/pull/18867/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #18867: Revert "[PIP-167][Authorization] Make it Configurable to Require Subscription Permission"
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #18867:
URL: https://github.com/apache/pulsar/pull/18867#issuecomment-1345465252
@tisonkun, it seems like we should update the "semantic pull request" check to allow this kind of PR to get merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org