You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/02 11:59:44 UTC
[GitHub] [incubator-inlong] healchow opened a new pull request #2835: [INLONG-2821][Manager] Change the status of the source after receiving the task snapshot
healchow opened a new pull request #2835:
URL: https://github.com/apache/incubator-inlong/pull/2835
### Title Name: [INLONG-2821][Manager] Change the status of the source after receiving the task snapshot
Fixes #2821
### Motivation
Change the status of the source after receiving the task snapshot.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [X] Make sure that the change passes the CI checks.
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #2835: [INLONG-2821][Manager] Change the status of the source after receiving the task snapshot
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2835:
URL: https://github.com/apache/incubator-inlong/pull/2835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2835: [INLONG-2821][Manager] Change the status of the source after receiving the task snapshot
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2835:
URL: https://github.com/apache/incubator-inlong/pull/2835#discussion_r817674712
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/SourceSnapshotOperation.java
##########
@@ -104,13 +163,33 @@ public void close() {
this.isClose = true;
}
+ /**
+ * Get all tasks in a temporary state, and set up an ip-id-status map,
+ * the temporary state is greater than or equal to 200.
+ *
+ * @see org.apache.inlong.manager.common.enums.SourceState
+ */
+ private ConcurrentHashMap<String, ConcurrentHashMap<Integer, Integer>> getTaskIpAndStatusMap() {
+ ConcurrentHashMap<String, ConcurrentHashMap<Integer, Integer>> ipTaskMap = new ConcurrentHashMap<>();
Review comment:
I'll add a default capacity in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] EMsnap commented on a change in pull request #2835: [INLONG-2821][Manager] Change the status of the source after receiving the task snapshot
Posted by GitBox <gi...@apache.org>.
EMsnap commented on a change in pull request #2835:
URL: https://github.com/apache/incubator-inlong/pull/2835#discussion_r817671729
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/SourceSnapshotOperation.java
##########
@@ -104,13 +163,33 @@ public void close() {
this.isClose = true;
}
+ /**
+ * Get all tasks in a temporary state, and set up an ip-id-status map,
+ * the temporary state is greater than or equal to 200.
+ *
+ * @see org.apache.inlong.manager.common.enums.SourceState
+ */
+ private ConcurrentHashMap<String, ConcurrentHashMap<Integer, Integer>> getTaskIpAndStatusMap() {
+ ConcurrentHashMap<String, ConcurrentHashMap<Integer, Integer>> ipTaskMap = new ConcurrentHashMap<>();
Review comment:
better to have default capacity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org