You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/26 06:52:03 UTC

[GitHub] [superset] zhaoyongjie commented on pull request #19842: fix: count(distinct column_name) in metrics

zhaoyongjie commented on PR #19842:
URL: https://github.com/apache/superset/pull/19842#issuecomment-1109414800

   > Lgtm! 1 suggestion - should we rename `COUNT_DISTINCT` to `COUNT DISTINCT` on our list of aggregates in Simple tab?
   
   Thanks @kgabryje! the `count_distinct` is used for a lot of places, and `COUNT_DISTINCT` also affects label(verbose name in query), so I didn't modify it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org