You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/03/21 15:52:37 UTC
Review Request 57810: Stack Advisor reported an error: KeyError:
'nimbus.authorizer' during Test Kerberos Client command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518
Repository: ambari
Description
-------
Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 555cf4d
Diff: https://reviews.apache.org/r/57810/diff/1/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 57810: Stack Advisor reported an error: KeyError:
'nimbus.authorizer' during Test Kerberos Client command
Posted by Robert Levas <rl...@hortonworks.com>.
> On March 21, 2017, 12:18 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
> > Lines 499-503 (original), 499-503 (patched)
> > <https://reviews.apache.org/r/57810/diff/1/?file=1670925#file1670925line499>
> >
> > What should `numbus.authorizer` be set to if security is enabled and the Ranger plug-in is not enabled?
Oops... I misread the code... but there is still no clause to support `rangerPluginEnabled` = `None` or `rangerPluginEnabled` = `''` - `rangerPluginEnabled` resolving to false.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169567
-----------------------------------------------------------
On March 21, 2017, 11:52 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 11:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 555cf4d
>
>
> Diff: https://reviews.apache.org/r/57810/diff/1/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 57810: Stack Advisor reported an error: KeyError:
'nimbus.authorizer' during Test Kerberos Client command
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169567
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
Lines 499-503 (original), 499-503 (patched)
<https://reviews.apache.org/r/57810/#comment241983>
What should `numbus.authorizer` be set to if security is enabled and the Ranger plug-in is not enabled?
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
Line 502 (original), 502 (patched)
<https://reviews.apache.org/r/57810/#comment241982>
Does `'No'.lower()` != `'no'`?
- Robert Levas
On March 21, 2017, 11:52 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 11:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 555cf4d
>
>
> Diff: https://reviews.apache.org/r/57810/diff/1/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 57810: Stack Advisor reported an error: KeyError:
'nimbus.authorizer' during Test Kerberos Client command
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169586
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On March 21, 2017, 1:19 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 1:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 555cf4d
>
>
> Diff: https://reviews.apache.org/r/57810/diff/3/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 57810: Stack Advisor reported an error: KeyError:
'nimbus.authorizer' during Test Kerberos Client command
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
-----------------------------------------------------------
(Updated \u041c\u0430\u0440\u0442 21, 2017, 5:19 \u043f.\u043f.)
Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518
Repository: ambari
Description
-------
Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 555cf4d
Diff: https://reviews.apache.org/r/57810/diff/3/
Changes: https://reviews.apache.org/r/57810/diff/2-3/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 57810: Stack Advisor reported an error: KeyError:
'nimbus.authorizer' during Test Kerberos Client command
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
-----------------------------------------------------------
(Updated \u041c\u0430\u0440\u0442 21, 2017, 5:17 \u043f.\u043f.)
Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518
Repository: ambari
Description
-------
Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 555cf4d
Diff: https://reviews.apache.org/r/57810/diff/2/
Changes: https://reviews.apache.org/r/57810/diff/1-2/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen