You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Michael McCandless <lu...@mikemccandless.com> on 2009/06/09 17:43:29 UTC
bulk fixing svn eol-style?
We have a number of sources that don't have eol-style set to "native"...
This causes problems, eg, patches to such files become degenerate
(remove all lines, add all lines), which of course hides what really
changed.
So... are there any objections if I go through all our sources and set
the eol-style to native?
EG, will this cause conflicts if someone w/ pending changes does "svn
up" after I've done this? Will anything else "go wrong"?
I'll wait a day or two to do this if there are no objections...
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: bulk fixing svn eol-style?
Posted by Michael McCandless <lu...@mikemccandless.com>.
On Mon, Jun 22, 2009 at 5:35 PM, Michael
McCandless<lu...@mikemccandless.com> wrote:
> So I'll go make the bulk fixes shortly...
OK, done.
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: bulk fixing svn eol-style?
Posted by Michael McCandless <lu...@mikemccandless.com>.
On Mon, Jun 22, 2009 at 5:29 PM, Michael
McCandless<lu...@mikemccandless.com> wrote:
> I am still planning on doing this but was still nervous about the
> impact to anyone holding lots of pending patches against the affected
> files (and haven't managed to up and test it myself).
OK I just confirmed on Collector.java that nothing bad happens if you
svn up a change to native eol-style on sources where you have pending
changes.
So I'll go make the bulk fixes shortly...
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: bulk fixing svn eol-style?
Posted by Michael McCandless <lu...@mikemccandless.com>.
Sigh, I did have this set up, but then switched to a new env and
forgot to re-instate.
Thanks for the reminder!
I am still planning on doing this but was still nervous about the
impact to anyone holding lots of pending patches against the affected
files (and haven't managed to up and test it myself).
Mike
On Mon, Jun 22, 2009 at 4:34 PM, Chris
Hostetter<ho...@fucit.org> wrote:
>
> : We have a number of sources that don't have eol-style set to "native"...
>
> This should also serve as a reminder for all committers to make sure they
> have sane auto-prop configs for their svn client when "svn add"ing files
> -- SVN doesn't have any way to configure these on the server side, so
> you're responsible for setting them.
>
> The solr wiki has some recommended config options (which should probably
> get copied to the lucene-java wiki)...
>
> http://wiki.apache.org/solr/CommitterInfo#head-849f78497222f424339b79417056f4e510349fcb
>
>
>
> -Hoss
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: bulk fixing svn eol-style?
Posted by Chris Hostetter <ho...@fucit.org>.
: We have a number of sources that don't have eol-style set to "native"...
This should also serve as a reminder for all committers to make sure they
have sane auto-prop configs for their svn client when "svn add"ing files
-- SVN doesn't have any way to configure these on the server side, so
you're responsible for setting them.
The solr wiki has some recommended config options (which should probably
get copied to the lucene-java wiki)...
http://wiki.apache.org/solr/CommitterInfo#head-849f78497222f424339b79417056f4e510349fcb
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: bulk fixing svn eol-style?
Posted by DM Smith <dm...@gmail.com>.
Michael McCandless wrote:
> We have a number of sources that don't have eol-style set to "native"...
>
> This causes problems, eg, patches to such files become degenerate
> (remove all lines, add all lines), which of course hides what really
> changed.
>
> So... are there any objections if I go through all our sources and set
> the eol-style to native?
>
> EG, will this cause conflicts if someone w/ pending changes does "svn
> up" after I've done this? Will anything else "go wrong"?
>
The only way this would conflict is if two different people set the same
property at the same time.
> I'll wait a day or two to do this if there are no objections...
>
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org