You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "atahanyorganci (via GitHub)" <gi...@apache.org> on 2025/05/23 12:00:55 UTC
[PR] fix: Remove trailing whitespace in `Display` for `LogicalPlan::Projection` [datafusion]
atahanyorganci opened a new pull request, #16164:
URL: https://github.com/apache/datafusion/pull/16164
Remove trailing whitespace in `Display` for `LogicalPlan::Projection`. This prevents editors and other tools from automatically removing trailing whitespace at the end of lines.
## Which issue does this PR close?
--
## Rationale for this change
Most editors automatically remove trailing whitespace at end of lines on save/paste actions. This chnage removes trailing whitespace from implementation and snapshots for better developer experience.
## What changes are included in this PR?
--
## Are these changes tested?
Yes, all of the tests are updated with new expected print output.
## Are there any user-facing changes?
This change only effects output of `LogicalPlan::display_indent()` and is purely for DX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove trailing whitespace in `Display` for `LogicalPlan::Projection` [datafusion]
Posted by "atahanyorganci (via GitHub)" <gi...@apache.org>.
atahanyorganci commented on PR #16164:
URL: https://github.com/apache/datafusion/pull/16164#issuecomment-2907862590
thanks for the review @alamb
CI passed, I think we can merge it at your discretion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove trailing whitespace in `Display` for `LogicalPlan::Projection` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16164:
URL: https://github.com/apache/datafusion/pull/16164#issuecomment-2913539367
Thanks @atahanyorganci and @berkaysynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove trailing whitespace in `Display` for `LogicalPlan::Projection` [datafusion]
Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada merged PR #16164:
URL: https://github.com/apache/datafusion/pull/16164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org