You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Scholte (JIRA)" <ji...@codehaus.org> on 2013/02/03 11:57:14 UTC

[jira] (MNG-5429) REGRESSION: Injected Settings in a Mojo are missing the proxies from settings.xml

Robert Scholte created MNG-5429:
-----------------------------------

             Summary: REGRESSION: Injected Settings in a Mojo are missing the proxies from settings.xml 
                 Key: MNG-5429
                 URL: https://jira.codehaus.org/browse/MNG-5429
             Project: Maven 2 & 3
          Issue Type: Bug
          Components: Settings
    Affects Versions: 3.0.4, 3.0.3, 3.0.2, 3.0.1
            Reporter: Robert Scholte


If you have a Mojo with 

{code}
/**
 * @parameter expression="${settings}"
 * @required
 * @readonly
 */
private Settings settings; 
{code}

In Maven 2.2.1, the Settings included all the profiles, in Maven3 the proxies are all missing.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5429) REGRESSION: Injected Settings in a Mojo are missing the proxies from settings.xml

Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=318818#comment-318818 ] 

Robert Scholte commented on MNG-5429:
-------------------------------------

The problem seems to be in the {{org.apache.maven.execution.DefaultMavenExecutionRequestPopulator}}

{code}
        for ( Proxy proxy : settings.getProxies() )
        {
            if ( !proxy.isActive() )
            {
                continue;
            }

            proxy = proxy.clone();

            request.addProxy( proxy );
        }
{code}

This filtering seems to be done too early.
                
> REGRESSION: Injected Settings in a Mojo are missing the proxies from settings.xml 
> ----------------------------------------------------------------------------------
>
>                 Key: MNG-5429
>                 URL: https://jira.codehaus.org/browse/MNG-5429
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Settings
>    Affects Versions: 3.0.1, 3.0.2, 3.0.3, 3.0.4
>            Reporter: Robert Scholte
>
> If you have a Mojo with 
> {code}
> /**
>  * @parameter expression="${settings}"
>  * @required
>  * @readonly
>  */
> private Settings settings; 
> {code}
> In Maven 2.2.1, the Settings included all the profiles, in Maven3 the proxies are all missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5429) REGRESSION: Injected Settings in a Mojo are missing the proxies from settings.xml

Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=318597#comment-318597 ] 

Robert Scholte commented on MNG-5429:
-------------------------------------

To be precise: it is missing all inactive proxies. IMO these should still be part of the (effective-)settings.
                
> REGRESSION: Injected Settings in a Mojo are missing the proxies from settings.xml 
> ----------------------------------------------------------------------------------
>
>                 Key: MNG-5429
>                 URL: https://jira.codehaus.org/browse/MNG-5429
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Settings
>    Affects Versions: 3.0.1, 3.0.2, 3.0.3, 3.0.4
>            Reporter: Robert Scholte
>
> If you have a Mojo with 
> {code}
> /**
>  * @parameter expression="${settings}"
>  * @required
>  * @readonly
>  */
> private Settings settings; 
> {code}
> In Maven 2.2.1, the Settings included all the profiles, in Maven3 the proxies are all missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira