[jira] [Commented] (CB-7883) toURL() returns invalid URL values on windows

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193542#comment-14193542 ] 

ASF GitHub Bot commented on CB-7883:
------------------------------------

GitHub user vldmrrr opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/89

    Rework to use normal url form on windows platform

    CB-7883: toURL method called on etnries returned by resolveLocalFileSystemURL and getDirectory produces path instead of URL. 
    
    This rework produce url's in normal form. The code passes all automated tests, although some tests were massaged for windows platform.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vldmrrr/cordova-plugin-file CB-7883

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit 3dfd3e9afaa93dbbd880592e1c8f281b4091a252
Author: Vladimir Avdonin <vl...@gmail.com>
Date:   2014-11-01T22:40:54Z

    Rework to use normal url form on windows platform

----


> toURL() returns invalid URL values on windows
> ---------------------------------------------
>
>                 Key: CB-7883
>                 URL: https://issues.apache.org/jira/browse/CB-7883
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File, Windows
>    Affects Versions: 4.0.0
>            Reporter: Vladimir Avdonin
>
> toURL method called on etnries returned by resolveLocalFileSystemURL and getDirectory produces path instead of URL. Note also inconsistent use of forward/backward slash separator in test output below.
> Below is test program and its output, demonstrating the problem:
> {code}
> -----------------test program-----------------------
> window.resolveLocalFileSystemURL(
> 	'file:///',
> 	function(entry) {
> 		console.log('Root URL is '+entry.toURL());
> 		entry.getDirectory(
> 			'Subdir',
> 			{create:true},
> 			function(entry1) {
> 				console.log('Subdir URL is '+entry1.toURL());
> 			},
> 			function(err) { console.log(err); }
> 		);
> 	},
> 	function(err) { console.log(err); }
> );
> -------------output------------------------
> Root URL is C:/Users/vladimir/AppData/Local/Packages/com.example.hello_dsh9t8a1qg3mw/LocalState/
> Subdir URL is C:\Users\vladimir\AppData\Local\Packages\com.example.hello_dsh9t8a1qg3mw\LocalState\Subdir/
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org