[GitHub] [geode] igodwin opened pull request #4552: GEODE-7210: Fix RedundancyLevelPart1DUnitTest

["igodwin (GitHub)" <gi...@apache.org>]

Changes made to address flakiness:

- Inline super
- Implement Serializable
- Use Dunit rules DistributedRule and CacheRule
- Use AssertJ
- Use setup and teardown methods
- CountdownLatch rather than Thread.sleep
- No static methods

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4552 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp commented on pull request #4552: GEODE-7210: Fix RedundancyLevelPart1DUnitTest

["mhansonp (GitHub)" <gi...@apache.org>]

If you change the server from 3 in these ignored tests to 1, these tests pass. I am running a 1000 passes to see how they hold up. Might be worth adding them back in.

[ Full content available at: https://github.com/apache/geode/pull/4552 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #4552: GEODE-7210: Fix RedundancyLevelPart1DUnitTest

["kirklund (GitHub)" <gi...@apache.org>]

Another good thing to change is to move away from direct usage of implementation classes towards usage of interfaces. You'll find that this works:
```
InternalCacheServer cacheServer = (InternalCacheServer) cache.getCacheServers().iterator().next();
```

[ Full content available at: https://github.com/apache/geode/pull/4552 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp commented on issue #4552: GEODE-7210: Fix RedundancyLevelPart1DUnitTest

["mhansonp (GitHub)" <gi...@apache.org>]

Ahem... Spotless.

[ Full content available at: https://github.com/apache/geode/pull/4552 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] igodwin commented on pull request #4552: GEODE-7210: Fix RedundancyLevelPart1DUnitTest

["igodwin (GitHub)" <gi...@apache.org>]

Done, though not in setUp(). Default value for disableShufflingOfEndpoints is false so I removed the "reset" in tearDown().

[ Full content available at: https://github.com/apache/geode/pull/4552 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] igodwin commented on pull request #4552: GEODE-7210: Fix RedundancyLevelPart1DUnitTest

["igodwin (GitHub)" <gi...@apache.org>]

Done. Thank you.

[ Full content available at: https://github.com/apache/geode/pull/4552 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org