You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by gi...@apache.org on 2014/01/29 09:53:58 UTC

[23/50] git commit: updated refs/heads/marvin to df58f51

CLOUDSTACK-5900: Failed to delete template/ISO that failed to download.


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/d7ee7a74
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/d7ee7a74
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/d7ee7a74

Branch: refs/heads/marvin
Commit: d7ee7a74315fd13b1fd3e4701e8810788aa1e680
Parents: 53feeca
Author: Sanjay Tripathi <sa...@citrix.com>
Authored: Tue Jan 28 19:09:26 2014 +0530
Committer: Sanjay Tripathi <sa...@citrix.com>
Committed: Tue Jan 28 19:21:10 2014 +0530

----------------------------------------------------------------------
 .../resource/NfsSecondaryStorageResource.java       | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/d7ee7a74/services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
----------------------------------------------------------------------
diff --git a/services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java b/services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
index 30722e2..4d11dd3 100755
--- a/services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
+++ b/services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
@@ -1716,16 +1716,16 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S
                 parent += File.separator;
             }
             String absoluteTemplatePath = parent + relativeTemplatePath;
-            File tmpltParent = new File(absoluteTemplatePath).getParentFile();
+            File tmpltDir = new File(absoluteTemplatePath);
             String details = null;
-            if (!tmpltParent.exists()) {
-                details = "template parent directory " + tmpltParent.getName() + " doesn't exist";
+            if (!tmpltDir.exists()) {
+                details = "template parent directory " + tmpltDir.getName() + " doesn't exist";
                 s_logger.debug(details);
                 return new Answer(cmd, true, details);
             }
-            File[] tmpltFiles = tmpltParent.listFiles();
+            File[] tmpltFiles = tmpltDir.listFiles();
             if (tmpltFiles == null || tmpltFiles.length == 0) {
-                details = "No files under template parent directory " + tmpltParent.getName();
+                details = "No files under template parent directory " + tmpltDir.getName();
                 s_logger.debug(details);
             } else {
                 boolean found = false;
@@ -1751,12 +1751,12 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S
                 }
 
                 if (!found) {
-                    details = "Can not find template.properties under " + tmpltParent.getName();
+                    details = "Can not find template.properties under " + tmpltDir.getName();
                     s_logger.debug(details);
                 }
             }
-            if (!tmpltParent.delete()) {
-                details = "Unable to delete directory " + tmpltParent.getName() + " under Template path " + relativeTemplatePath;
+            if (!tmpltDir.delete()) {
+                details = "Unable to delete directory " + tmpltDir.getName() + " under Template path " + relativeTemplatePath;
                 s_logger.debug(details);
                 return new Answer(cmd, false, details);
             }