You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2023/05/23 19:15:17 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #5983: [JS] Fix ConcurrentModificationException scanning export class {} with multiple members
matthiasblaesing opened a new pull request, #5983:
URL: https://github.com/apache/netbeans/pull/5983
Fix applies same pattern, that is used in other places where ModelUtils#moveProperty is invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5983: [JS] Fix ConcurrentModificationException scanning export class {} with multiple members
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5983:
URL: https://github.com/apache/netbeans/pull/5983#issuecomment-1568209769
OK, moving this on to master so that we can get rid of the delivery branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on a diff in pull request #5983: [JS] Fix ConcurrentModificationException scanning export class {} with multiple members
Posted by "lbownik (via GitHub)" <gi...@apache.org>.
lbownik commented on code in PR #5983:
URL: https://github.com/apache/netbeans/pull/5983#discussion_r1203547539
##########
webcommon/javascript2.model/src/org/netbeans/modules/javascript2/model/ModelVisitor.java:
##########
@@ -712,8 +712,9 @@ public boolean enterClassNode(ClassNode node) {
);
JsObject origClassObject = parent.getProperty(className.getName());
if (origClassObject != null) {
- for (Entry<String, ? extends JsObject> e : origClassObject.getProperties().entrySet()) {
- ModelUtils.moveProperty(classObject, e.getValue());
+ List<JsObject> properties = new ArrayList<>(origClassObject.getProperties().values());
Review Comment:
is there a specific reason for creating a new ArrayList ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #5983: [JS] Fix ConcurrentModificationException scanning export class {} with multiple members
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #5983:
URL: https://github.com/apache/netbeans/pull/5983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5983: [JS] Fix ConcurrentModificationException scanning export class {} with multiple members
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5983:
URL: https://github.com/apache/netbeans/pull/5983#issuecomment-1560014552
> Fix applies same pattern, that is used in other places where ModelUtils#moveProperty is invoked.
i see one change in ModelVisitor. This sentence sounds like there should be multiple fixes in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5983: [JS] Fix ConcurrentModificationException scanning export class {} with multiple members
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5983:
URL: https://github.com/apache/netbeans/pull/5983#issuecomment-1560023057
> > Fix applies same pattern, that is used in other places where ModelUtils#moveProperty is invoked.
>
> i see one change in ModelVisitor. This sentence sounds like there should be multiple fixes in this PR?
Missunderstanding, I meant, that other location with similar structure, already hold the fix for `ConcurrentModificationException`:
https://github.com/apache/netbeans/blob/788ba1f72534348ac9e45210c7edd2428659d2b4/webcommon/javascript2.model/src/org/netbeans/modules/javascript2/model/JsObjectImpl.java#L488-L491
https://github.com/apache/netbeans/blob/788ba1f72534348ac9e45210c7edd2428659d2b4/webcommon/javascript2.model/src/org/netbeans/modules/javascript2/model/ModelVisitor.java#L1014-L1017
https://github.com/apache/netbeans/blob/788ba1f72534348ac9e45210c7edd2428659d2b4/webcommon/javascript2.model/src/org/netbeans/modules/javascript2/model/api/ModelUtils.java#L1917-L1920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5983: [JS] Fix ConcurrentModificationException scanning export class {} with multiple members
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5983:
URL: https://github.com/apache/netbeans/pull/5983#issuecomment-1560675262
Thanks @matthiasblaesing Adding label pending discussion on dev@ Will only go into delivery if we have an 18-rc5. Otherwise, should go in to master and be a possible cherry pick candidate to release180 for an 18-u1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists