You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by roshan <gi...@git.apache.org> on 2017/05/09 17:35:03 UTC

[GitHub] thrift pull request #1264: Set default max read buffer size in Java server

GitHub user roshan opened a pull request:

    https://github.com/apache/thrift/pull/1264

    Set default max read buffer size in Java server

    This is for the non-blocking server. This makes it so that just starting up something with all defaults won't result in it being possible to construct an input that causes it to OOME by just filling up the read buffer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/roshan/thrift THRIFT-4193

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1264
    
----
commit e8e2f4ee0912beb8a1f8fbd2b4ab15b1e8ab6d90
Author: Roshan George <rg...@liveramp.com>
Date:   2017-05-09T17:32:09Z

    Set default max read buffer size in Java server
    
    This is for the non-blocking server.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1264: THRIFT-4193 Set default max read buffer size in J...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1264


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1264: THRIFT-4193 Set default max read buffer size in Java ser...

Posted by roshan <gi...@git.apache.org>.
Github user roshan commented on the issue:

    https://github.com/apache/thrift/pull/1264
  
    It is configurable using the `maxReadBufferBytes` argument, but the default is just really high.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---